From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0208C43331 for ; Thu, 5 Sep 2019 15:01:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37FD9206A5 for ; Thu, 5 Sep 2019 15:01:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="clxDekQB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37FD9206A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5mOgLZP4Ii0m0QTU4nuoRAQcmFpMmkbYRXwV+UcfkkE=; b=clxDekQBi83Qpt uxekHsnZ4bf+VSp2rZWDxsbo6OrC5eZvCNfZ5NFqDJ0o0tdAuE6OCq6e/1BRBhsJaKmLUdRM6BZet M/cHRiuZSH5aTHY31KrcK5QYTEFOFi+hRtRV2KkEUoNwm4QlTPXlqa+Gz9M8dvpy2fnTrcXvVBNmA A5EkwPhh3PvviehjQore70XXnyBlJMRpn9W7TAULmCWaJVJv/c1vd2vvXOkF0w2BXxOTZmEo4gMox UG8u67OCmEF9Xuvh01laigSivDK9RG3mhinE27v4piSVXDqKT5RZRp+JKGZT5Wf+pBHfo1dfbxorX RU+gfIODruIJ5QUc5L3g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i5tGK-0004rO-CP; Thu, 05 Sep 2019 15:01:28 +0000 Received: from mga04.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i5tG0-0004iY-Kt for linux-nvme@lists.infradead.org; Thu, 05 Sep 2019 15:01:09 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Sep 2019 08:01:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,470,1559545200"; d="scan'208";a="195119894" Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by orsmga002.jf.intel.com with ESMTP; 05 Sep 2019 08:01:06 -0700 Date: Thu, 5 Sep 2019 08:59:38 -0600 From: Keith Busch To: Israel Rukshin Subject: Re: [PATCH] nvme: Remove double assignment of cq vector Message-ID: <20190905145937.GB24939@localhost.localdomain> References: <1567695048-5234-1-git-send-email-israelr@mellanox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1567695048-5234-1-git-send-email-israelr@mellanox.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190905_080108_700115_147D2F3F X-CRM114-Status: GOOD ( 14.51 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Max Gurtovoy , Christoph Hellwig , Linux-nvme , Sagi Grimberg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Sep 05, 2019 at 02:50:48PM +0000, Israel Rukshin wrote: > Poll queues don't use it, so the assignment should be only when > using IRQs. It's not really a double assignment. An interrupt driven queue may become a polled queue after a reset, in which case this assignment serves to clear it's previously assigned vector. It doesn't actually appear to matter if we've cleared it or not when the NVMEQ_POLLED flag is set, though. > Signed-off-by: Israel Rukshin > Reviewed-by: Max Gurtovoy > --- > drivers/nvme/host/pci.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c > index 10d3071d6098..492074c95b9b 100644 > --- a/drivers/nvme/host/pci.c > +++ b/drivers/nvme/host/pci.c > @@ -1560,7 +1560,6 @@ static int nvme_create_queue(struct nvme_queue *nvmeq, int qid, bool polled) > else if (result) > goto release_cq; > > - nvmeq->cq_vector = vector; > nvme_init_queue(nvmeq, qid); > > if (!polled) { > -- > 2.16.3 _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme