Re: [PATCH 2/2] nvme: add API for getting nsid by bdev

From: kbuild test robot <lkp@intel.com>
To: Robert Baldyga <robert.baldyga@intel.com>
Cc: sagi@grimberg.me, linux-kernel@vger.kernel.org,
	linux-nvme@lists.infradead.org, michal.rakowski@intel.com,
	axboe@fb.com, kbuild-all@01.org,
	Robert Baldyga <robert.baldyga@intel.com>,
	kbusch@kernel.org, hch@lst.de
Subject: Re: [PATCH 2/2] nvme: add API for getting nsid by bdev
Date: Mon, 16 Sep 2019 14:57:08 +0800	[thread overview]
Message-ID: <201909161414.wRn53neW%lkp@intel.com> (raw)
In-Reply-To: <20190913111610.9958-3-robert.baldyga@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2430 bytes --]

Hi Robert,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3 next-20190915]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Robert-Baldyga/nvme-Add-kernel-API-for-admin-command/20190916-134358
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=sparc64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/linkage.h:7:0,
                    from include/linux/kernel.h:8,
                    from include/asm-generic/bug.h:18,
                    from arch/sparc/include/asm/bug.h:25,
                    from include/linux/bug.h:5,
                    from include/linux/thread_info.h:12,
                    from arch/sparc/include/asm/current.h:15,
                    from include/linux/sched.h:12,
                    from include/linux/blkdev.h:5,
                    from drivers/nvme/host/core.c:7:
>> drivers/nvme/host/core.c:827:19: error: 'nvme_nsid_by_bdev' undeclared here (not in a function); did you mean 'nvme_get_nsid_by_bdev'?
    EXPORT_SYMBOL_GPL(nvme_nsid_by_bdev);
                      ^
   include/linux/export.h:79:16: note: in definition of macro '___EXPORT_SYMBOL'
     extern typeof(sym) sym;      \
                   ^~~
>> drivers/nvme/host/core.c:827:1: note: in expansion of macro 'EXPORT_SYMBOL_GPL'
    EXPORT_SYMBOL_GPL(nvme_nsid_by_bdev);
    ^~~~~~~~~~~~~~~~~

vim +827 drivers/nvme/host/core.c

   814	
   815	int nvme_get_nsid_by_bdev(struct block_device *bdev, unsigned int *nsid)
   816	{
   817		struct nvme_ns *ns;
   818	
   819		if (!bdev && !nsid)
   820			return -EINVAL;
   821	
   822		ns = bdev->bd_disk->private_data;
   823		*nsid = ns->head->ns_id;
   824	
   825		return 0;
   826	}
 > 827	EXPORT_SYMBOL_GPL(nvme_nsid_by_bdev);
   828	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 58661 bytes --]

[-- Attachment #3: Type: text/plain, Size: 158 bytes --]

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme