From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 785EEC49ED7 for ; Mon, 16 Sep 2019 16:01:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A880214D9 for ; Mon, 16 Sep 2019 16:01:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KBs54cbH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A880214D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HOOWBQn4yiWS0jnlQoSIzqB/9JGRl1dQZBThOgB8aDk=; b=KBs54cbH69Wzn3 vQr/jcqvmeu2S3Fvm3YAAUPUoHfyfv8DqqbbqR+gFQrbdxca2gOm/tYH3epFzjPFeFz9qynTuZoVp vPAE+Du8jhwHcmTx8sRFERCOzB+Nnzqs7xN9j3iRWJz4B50Tlj6kNo/EfU0KoyB6K+srhMFRalqO+ sbf7TgRWlQSnBeUyxH8SLPM0YFUP9Wlj83J+flGtwZ3dJzWD9GL1MNKo8qsxvp4Ha0Pi0Ne685aHF TggMUJy8rFSUbMhy3iaZLMFyJUreHyncw36lyML51s0/6rsqvukOalZjql9fZMkQ4+1eOJafJfJQd EVorDbmspkoqwlC5x7WA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i9tRO-0006oM-LU; Mon, 16 Sep 2019 16:01:26 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1i9tRL-0006nv-Qn for linux-nvme@lists.infradead.org; Mon, 16 Sep 2019 16:01:25 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 6232968B05; Mon, 16 Sep 2019 18:01:18 +0200 (CEST) Date: Mon, 16 Sep 2019 18:01:17 +0200 From: "hch@lst.de" To: "Singh, Balbir" Subject: Re: [PATCH v2 2/2] nvme/host/core: Allow overriding of wait_ready timeout Message-ID: <20190916160117.GB1455@lst.de> References: <20190913233631.15352-1-sblbir@amzn.com> <20190913233631.15352-2-sblbir@amzn.com> <20190916074153.GA25606@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190916_090124_013186_A0FEF3EE X-CRM114-Status: GOOD ( 11.00 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "sblbir@amzn.com" , "sagi@grimberg.me" , "linux-nvme@lists.infradead.org" , "axboe@fb.com" , "kbusch@kernel.org" , "hch@lst.de" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Sep 16, 2019 at 12:33:31PM +0000, Singh, Balbir wrote: > > Then again I'm not even sure we really want this. The debugging use > > case is somethign where you can easily hack a line in the driver, and > > we really don't want normal users to mess with a random parameter > > like > > this one. > > The reason I sent this out is that I've seen some controllers setting > this to max value. I suspect there is no good way for the controller > to set wait ready values either. In any case 128 seconds for a failure > seems a bit too much, specially if the controller does not respond on > boot and hence the debug option. I don't expect it to be used by normal > users on most of their systems The problem with these tweaks is that people will touch them for weird reasons. Another one is that a module parameter is global, while many settings should be per-controller (although that would add even more boilerplate code). _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme