From: Keith Busch <kbusch@kernel.org>
To: Mario Limonciello <mario.limonciello@dell.com>
Cc: Crag Wang <Crag.Wang@dell.com>, Sagi Grimberg <sagi@grimberg.me>,
sjg@google.com, LKML <linux-kernel@vger.kernel.org>,
linux-nvme@lists.infradead.org, Jens Axboe <axboe@fb.com>,
Ryan Hong <Ryan.Hong@Dell.com>,
Jared Dominguez <jared.dominguez@dell.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2] nvme-pci: Save PCI state before putting drive into deepest state
Date: Fri, 20 Sep 2019 11:46:13 -0600 [thread overview]
Message-ID: <20190920174613.GA97775@C02WT3WMHTD6> (raw)
In-Reply-To: <1568830555-11531-1-git-send-email-mario.limonciello@dell.com>
On Wed, Sep 18, 2019 at 01:15:55PM -0500, Mario Limonciello wrote:
> The action of saving the PCI state will cause numerous PCI configuration
> space reads which depending upon the vendor implementation may cause
> the drive to exit the deepest NVMe state.
>
> In these cases ASPM will typically resolve the PCIe link state and APST
> may resolve the NVMe power state. However it has also been observed
> that this register access after quiesced will cause PC10 failure
> on some device combinations.
>
> To resolve this, move the PCI state saving to before SetFeatures has been
> called. This has been proven to resolve the issue across a 5000 sample
> test on previously failing disk/system combinations.
>
> Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
This looks good. It clashes with something I posted yesterday, but
I'll rebase after this one.
Reviewed-by: Keith Busch <kbusch@kernel.org>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-09-20 17:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 18:15 [PATCH v2] nvme-pci: Save PCI state before putting drive into deepest state Mario Limonciello
2019-09-20 17:16 ` Sagi Grimberg
2019-09-20 17:46 ` Keith Busch [this message]
2019-09-27 21:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920174613.GA97775@C02WT3WMHTD6 \
--to=kbusch@kernel.org \
--cc=Crag.Wang@dell.com \
--cc=Ryan.Hong@Dell.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=jared.dominguez@dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mario.limonciello@dell.com \
--cc=sagi@grimberg.me \
--cc=sjg@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).