From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AECA5C3A5A2 for ; Fri, 20 Sep 2019 18:18:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8958920717 for ; Fri, 20 Sep 2019 18:18:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WQ4oFqKL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8958920717 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=grimberg.me Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=MfHezGOKvQ6Sj/FGOwzC5Gapvj15MM5TtAEzpg+2kpA=; b=WQ4 oFqKLZGJX68dafUb4buVgl58pmaH7fpXuG6Z0pHRoXMRQhshMY29IJxqRx/xS3ClB8DZrV45hjyf5 i1dNeclGq6I5hTh39jGkJXBX17h30AhpJN/99BUM+lUOtXgZgpuL0DbGQJ2q/1RrYnxHpO0GbDkd2 TafqOfo4up6NfZLQRY1rFBs9q4aUT/pvgbvOVgdjaB99BxxFFSNRCj2AeN8cl4AL4WkL95ZOcrT2s K/JsZPYJsj4VjqfYKX0jRmY9NjIXKx2PoWX1bR0gExRDFaozWEgVHl/mCvzgL4b4Ku+W2dDZbB9M+ qIBJkIrcBIX2JWc4MbbJeKfiy4Q5YYQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iBNU6-0006ya-IL; Fri, 20 Sep 2019 18:18:22 +0000 Received: from [2600:1700:65a0:78e0:514:7862:1503:8e4d] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.92.2 #3 (Red Hat Linux)) id 1iBNU4-0006yL-IT; Fri, 20 Sep 2019 18:18:20 +0000 From: Sagi Grimberg To: linux-nvme@lists.infradead.org Subject: [PATCH 1/2] scatterlist: make sgl_free null pointer safe Date: Fri, 20 Sep 2019 11:18:17 -0700 Message-Id: <20190920181818.14424-1-sagi@grimberg.me> X-Mailer: git-send-email 2.17.1 X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Busch , Christoph Hellwig MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Match other alloc/free routines by checking the sgl pointer first. Signed-off-by: Sagi Grimberg --- lib/scatterlist.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/scatterlist.c b/lib/scatterlist.c index c2cf2c311b7d..fea25b035e67 100644 --- a/lib/scatterlist.c +++ b/lib/scatterlist.c @@ -563,6 +563,9 @@ void sgl_free_n_order(struct scatterlist *sgl, int nents, int order) struct page *page; int i; + if (!sgl) + return; + for_each_sg(sgl, sg, nents, i) { if (!sg) break; -- 2.17.1 _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme