From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C96BC4360C for ; Fri, 27 Sep 2019 21:35:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F8132075D for ; Fri, 27 Sep 2019 21:35:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kCQs2BtY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F8132075D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R1QCJIOlhEsNi5VUDpXPmM923MWS3mA7HEPt3Z8ykvw=; b=kCQs2BtYvqIfkv 2Au4EZbB5N7ODjngKCT0IQ2wYaDPVqQouF/m3ii+NQSq9QM9Vb4Pw5u8ZN6RVrAxcOBtJsWaEYLBA lsbMJ3dYCtyqlFUKm21ht59NATSMCk/d2y+HIuvG7tqHNyblaS2ijMZURNp+Aye0Zxk9xw5QHOC9l N5R2ydRGhlcJ3yGzeAUk5dcg/SP7fho335gvIOPdPuaqfphRD33IizYBc35UwgUE8p3Rl4xyBSw1l IU4chAJTTDD3UtLQFSQiOHj/7q+FYXMnTCGv8LfG7N1pxHPCI1vrKvXggOooVi5KkPLqeKdsdRXSR DIwMv6/svGcau81q30Tw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDxtf-0002Xq-Uq; Fri, 27 Sep 2019 21:35:27 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDxtc-0002XN-Cd for linux-nvme@lists.infradead.org; Fri, 27 Sep 2019 21:35:26 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id A41E468B05; Fri, 27 Sep 2019 23:35:21 +0200 (CEST) Date: Fri, 27 Sep 2019 23:35:21 +0200 From: Christoph Hellwig To: kbusch@kernel.org Subject: Re: [PATCHv2 2/6] nvme: Remove ADMIN_ONLY state Message-ID: <20190927213521.GH16819@lst.de> References: <20190919213431.7864-1-kbusch@kernel.org> <20190919213431.7864-3-kbusch@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190919213431.7864-3-kbusch@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190927_143524_585682_0E80D5F8 X-CRM114-Status: UNSURE ( 8.43 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: James Smart , Edmund Nadolski , Sagi Grimberg , linux-nvme@lists.infradead.org, Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, Sep 20, 2019 at 06:34:27AM +0900, kbusch@kernel.org wrote: > @@ -3585,11 +3571,9 @@ static void nvme_scan_work(struct work_struct *work) > struct nvme_id_ctrl *id; > unsigned nn; > > - if (ctrl->state != NVME_CTRL_LIVE) > + if (ctrl->state != NVME_CTRL_LIVE || !ctrl->tagset) > return; > > - WARN_ON_ONCE(!ctrl->tagset); > - It would be nice to throw in a comment here on why tagset can be NULL here and what that means to make this a little easier to decode for future hackers. Except for that the patch looks fine to me. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme