From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4147C4360C for ; Fri, 27 Sep 2019 21:43:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8479A2146E for ; Fri, 27 Sep 2019 21:43:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="e2UZlGte" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8479A2146E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xH5gm0xP5o9A7izOylSI40zSf6/sRTsOG7pCvIdPEMU=; b=e2UZlGtessagpd k4SIMSsBSr+90E+MMA4BhKj9aiPv3kphwQOIK6V5pKE2JN5etLp0olvt3iFSmvwifSCEOxeFnJzMW YFPNRdLLbabyvFAyIUJnHUrqFfOYk/ysjc1eqeqKk4kygt+7GURvbDD5z9NIGd7mlQAM+7RX3LH/R NeLppCZrxQuvaLKem6q6ytcYd4ZrGDAWvX6vjuxnZatUsJ1UA8bvhX4xM6AJ76i2GsRuqLirD1Q+1 2ldSWQhDz4X7bpiiJbTEhHw8NPour7GMilFZQWn4bwmIcEUSwHrCjfmpy6R7DtiDQY/k+6Z6UJflu s+II448I+Y6xQqfhblNw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDy1c-0005C6-TS; Fri, 27 Sep 2019 21:43:40 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDy1Z-00056h-ST for linux-nvme@lists.infradead.org; Fri, 27 Sep 2019 21:43:39 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 3F00768B05; Fri, 27 Sep 2019 23:43:34 +0200 (CEST) Date: Fri, 27 Sep 2019 23:43:34 +0200 From: Christoph Hellwig To: kbusch@kernel.org Subject: Re: [PATCHv2 6/6] nvme: Wait for reset state when required Message-ID: <20190927214333.GL16819@lst.de> References: <20190919213431.7864-1-kbusch@kernel.org> <20190919213431.7864-7-kbusch@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190919213431.7864-7-kbusch@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190927_144338_072705_2B6FECCD X-CRM114-Status: UNSURE ( 5.72 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: James Smart , Edmund Nadolski , Sagi Grimberg , linux-nvme@lists.infradead.org, Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org > +/* > + * Returns false for sink states that can't ever transition back to live. > + */ > +static bool nvme_state_transient(struct nvme_ctrl *ctrl) Can we invert the logic and name? static bool nvme_state_terminal(struct nvme_ctrl *ctrl) or so? Transient always makes me thing of something with a very short life time. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme