From: Christoph Hellwig <hch@lst.de>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: sagi@grimberg.me, ilias.apalodimas@linaro.org,
linux-nvme@lists.infradead.org, axboe@fb.com, kbusch@kernel.org,
hch@lst.de
Subject: Re: [PATCH v2] nvme: retain split access workaround for capability reads
Date: Sun, 6 Oct 2019 11:14:20 +0200 [thread overview]
Message-ID: <20191006091420.GB25381@lst.de> (raw)
In-Reply-To: <20191003115729.8988-1-ard.biesheuvel@linaro.org>
> static int nvme_pci_reg_read64(struct nvme_ctrl *ctrl, u32 off, u64 *val)
> {
> - *val = readq(to_nvme_dev(ctrl)->bar + off);
> + *val = lo_hi_readq(to_nvme_dev(ctrl)->bar + off);
Please add a comment why we are doing this.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2019-10-06 9:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 11:57 [PATCH v2] nvme: retain split access workaround for capability reads Ard Biesheuvel
2019-10-06 9:14 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191006091420.GB25381@lst.de \
--to=hch@lst.de \
--cc=ard.biesheuvel@linaro.org \
--cc=axboe@fb.com \
--cc=ilias.apalodimas@linaro.org \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).