From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25332C4360C for ; Sun, 6 Oct 2019 10:12:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B10B920673 for ; Sun, 6 Oct 2019 10:12:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mp94zJGO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B10B920673 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i7e4vaC+zofmQrI91iA6ESwDNEHTUAUOE5Q78zdwMxw=; b=mp94zJGOGyIfa1 4Fn2VpezV+mIXQHvtsguxARNRYCH7P2fR1B4EHKQ29J7XPkdVkGOi66gaaTe83m2ku7Rn0NMkKy88 NjZPvlBvBTuBnLOnGpF7tccrYKB3B3Ky+n9DE60ZZPzWS1B3ey/zz5w74aDqskX1KPkyec/vQCoWE LXFAbX2GZ4JNIwiQ+IR84syAc/3BkP450pQ60zl61tniaYeeVvbkx2r9jIJfuUb5Qk1NqgpYoQZT+ xU5PkEV5v3QoSdCcVf2LesS0aOkEF2UI5w/ajsqRxF4/lfFVZiPAbKYSC/kUgitp+m8beENbeO3Sv 4kRDfQKURvJ2IsxeARug==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iH3WS-0007t7-2j; Sun, 06 Oct 2019 10:12:16 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.92.2 #3 (Red Hat Linux)) id 1iH3WP-0007sr-Qs; Sun, 06 Oct 2019 10:12:13 +0000 Date: Sun, 6 Oct 2019 03:12:13 -0700 From: Christoph Hellwig To: Sagi Grimberg Subject: Re: [PATCH v2] nvmet: add revalidate ns sysfs attribute to handle device resize Message-ID: <20191006101213.GA30175@infradead.org> References: <20190926231940.7494-1-m.malygin@yadro.com> <20190930150202.9259-1-m.malygin@yadro.com> <11e37d39-c85e-f844-953f-f540596b4410@grimberg.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <11e37d39-c85e-f844-953f-f540596b4410@grimberg.me> User-Agent: Mutt/1.12.1 (2019-06-15) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: m.malygin@yadro.com, linux-nvme@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, Oct 04, 2019 at 05:03:36PM -0700, Sagi Grimberg wrote: > This looks fine to me, > > Christoph, you happy with this version? > Conceptually yes, but it really needs to at least follow the kernel style. I'm also not sure I'm happy about all the extra indirections, but I can be talked into it. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme