From: Christoph Hellwig <hch@infradead.org>
To: Keith Busch <kbusch@kernel.org>
Cc: "Javier González" <javier@javigon.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"Chaitanya Kulkarni" <Chaitanya.Kulkarni@wdc.com>
Subject: Re: [PATCH] nvme: define struct for __nvme_submit_sync_cmd()
Date: Sun, 6 Oct 2019 03:13:22 -0700 [thread overview]
Message-ID: <20191006101322.GC30175@infradead.org> (raw)
In-Reply-To: <20191005144811.GB30437@keith-busch>
On Sat, Oct 05, 2019 at 08:48:12AM -0600, Keith Busch wrote:
> On Wed, Oct 02, 2019 at 06:10:09AM +0000, Chaitanya Kulkarni wrote:
> > On 10/1/19 10:47 PM, Javier González wrote:
> > > Makes sense to me. We have other places with similar arguments (e.g.,
> > > nvme_submit_user_cmd). Would it make sense to unify this too if we move
> > > in this direction?
> > >
> > Thanks for the feedback, I'll add that too in the next version.
>
> It also looks like much of the callers can use the much simpler
> nvme_submit_user_cmd() that already provides defaults to the numerous
> parameters.
That on the other hand actually seems like a useful change.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-10-06 10:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 23:13 [PATCH] nvme: define struct for __nvme_submit_sync_cmd() Chaitanya Kulkarni
2019-10-02 5:47 ` Javier González
2019-10-02 6:10 ` Chaitanya Kulkarni
2019-10-05 14:48 ` Keith Busch
2019-10-06 10:13 ` Christoph Hellwig [this message]
2019-10-05 0:09 ` Sagi Grimberg
2019-10-05 2:09 ` Balbir Singh
2019-10-06 10:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191006101322.GC30175@infradead.org \
--to=hch@infradead.org \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=javier@javigon.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).