From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 581F6ECE58C for ; Wed, 9 Oct 2019 22:10:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2FEF920B7C for ; Wed, 9 Oct 2019 22:10:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oWzUYQlS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fibYmpks" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FEF920B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7QnGpBLqGNohHFv03MKWGhyWhIEwj6Z3He0Ix/Kqbxg=; b=oWzUYQlS0JQmVR fQTvS5XHdpgaTQ3x2BngCqeexBnc1Bm4zxdaTPQ7JnnhRmJ7lWMjSu4QfXh+ahACvDRsz7wm+E9z2 DuCE1Ccp6mkHYA/jptNIBgYApip4IIcqhLkR+aMxvUJl0D7NXkSyZFsoEY7mO2loSRx5cqN75+nUq TEWZDsaG9PcD3EGlbN+PpiOB7tRDmVouKcv77rE9mi6LHu1Q/ympdYbH7C2m7rczGyjeJWmVJtizu suo3im5mMpDlQXhOYKWFQj+ApVc/3LcCAwKgyKsnUn+OlPwhnP5jDizga0wRE/TKQqmFyhlaImiOH C2D7eQ0CwFMTeOMGLUYw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iIKAQ-0005FL-Kl; Wed, 09 Oct 2019 22:10:46 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iIKAM-0005Ei-Q7 for linux-nvme@lists.infradead.org; Wed, 09 Oct 2019 22:10:44 +0000 Received: from washi1.fujisawa.hgst.com (unknown [199.255.47.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3C11220B7C; Wed, 9 Oct 2019 22:10:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570659042; bh=FQuEaTociCoUgYX9UFpVgH54MWKMMymSTxWUZxJ3XnU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fibYmpksKxqucYFycti50RMvVKSZpgpVeNGsXVejp7ozcybU6EPbMZJj/TesW1zp/ rLinlU5KdG5NhfECZx5qasQhFPVkQYKAWUEbSyQfs+497PpuxN2fwXGcP1Gix+UsIA bP91b+3hQqm55EMjmOaxmbZNr2wq4nhMRlga8JQY= Date: Thu, 10 Oct 2019 07:10:38 +0900 From: Keith Busch To: Sasha Levin Subject: Re: [PATCH 4.19] nvme: Assign subsys instance from first ctrl Message-ID: <20191009221038.GA3009@washi1.fujisawa.hgst.com> References: <20191009162910.1801-1-kbusch@kernel.org> <20191009215504.GW1396@sasha-vm> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191009215504.GW1396@sasha-vm> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191009_151042_864564_8E13F94A X-CRM114-Status: GOOD ( 14.38 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hannes Reinecke , Sagi Grimberg , stable@vger.kernel.org, linux-nvme@lists.infradead.org, Logan Gunthorpe , Christoph Hellwig , Minwoo Im Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Oct 09, 2019 at 05:55:04PM -0400, Sasha Levin wrote: > On Thu, Oct 10, 2019 at 01:29:10AM +0900, Keith Busch wrote: > > commit 733e4b69d508d03c20adfdcf4bd27abc60fae9cc upstream > > > > The namespace disk names must be unique for the lifetime of the > > subsystem. This was accomplished by using their parent subsystems' > > instances which were allocated independently from the controllers > > connected to that subsystem. This allowed name prefixes assigned to > > namespaces to match a controller from an unrelated subsystem, and has > > created confusion among users examining device nodes. > > > > Ensure a namespace's subsystem instance never clashes with a controller > > instance of another subsystem by transferring the instance ownership > > to the parent subsystem from the first controller discovered in that > > subsystem. > > > > Reviewed-by: Logan Gunthorpe > > Reviewed-by: Christoph Hellwig > > Reviewed-by: Minwoo Im > > Reviewed-by: Hannes Reinecke > > Reviewed-by: Sagi Grimberg > > Signed-off-by: Keith Busch > > Signed-off-by: Sagi Grimberg > > What are your thoughts about taking the following for 4.19 instead? > > 733e4b69d508d nvme: Assign subsys instance from first ctrl > e654dfd38c1ec nvme: fix memory leak caused by incorrect subsystem free > 32fd90c407680 nvme: change locking for the per-subsystem controller list > 092ff0520070f nvme: fix kernel paging oops > cb5b7262b011c nvme: provide fallback for discard alloc failure Thank you for the suggestion. I have reviewed the proposed sequence, and I would prefer to use this for stable instead of this back-ported patch. > -- > Thanks, > Sasha _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme