From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D089FECE58C for ; Wed, 9 Oct 2019 22:13:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5771218AC for ; Wed, 9 Oct 2019 22:13:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AQD0ZmWm"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ob9rAGSf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5771218AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hQPZdkV4wgv1E3Zo5wV30aFak3vDv3idX6yKwfyueIA=; b=AQD0ZmWmsPLkfP 1oWdBFT3H3JLoFF0pvt0Rp7IOi10vya0IugbzB6P71nnhz8OLBKgTyUgtiMX4gY8U4yZIyeV5//vN P+ShYgiJv1S2etcM5wlHnXVtnsQEQjuqd8MMYC/nPr+2JeeFhiKhtd6ZKtkHv627wO9Pzem/IMprU LaQy4Ue1pjEW74hwWvRR3FRVJsPo4vDM3OKJrMUQUwwPBDQEXUJm/wKCKxQxIxAehtSaTnZULYIZs 3tMizHPIaO7BCWRaIk9VKaD+2H6kYIJFbj8zG/KIzOWPKE3Gu2UroFutOOMmdXTJgBZ5stYLpWMUY Os1JgQaH/j5B7X2OlAAw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iIKDO-0006C0-IN; Wed, 09 Oct 2019 22:13:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iIKDM-0006Bc-8B for linux-nvme@lists.infradead.org; Wed, 09 Oct 2019 22:13:49 +0000 Received: from washi1.fujisawa.hgst.com (unknown [199.255.47.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A08B120B7C; Wed, 9 Oct 2019 22:13:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570659227; bh=RyPgVqyj3PPw8zKgkDtZVoZJBEN/mwASsfZ3X8viFlg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ob9rAGSf4kNkBMpSCe4SQ3shpy8EKIrmDLXF707Cgz9PzHJA6+ZVX3wqfOwpy3c94 4KqzrRhJaQyB3mDz9J4jyRqBVSABi8NN3laK0c/71U1sIEzkZjJGvGLqWrDmNtIGke PqJspaioXzcDujS0cyNGMv6SjJM66iv/A0BGWCEg= Date: Thu, 10 Oct 2019 07:13:44 +0900 From: Keith Busch To: Logan Gunthorpe Subject: Re: [PATCH v9 01/12] nvme-core: introduce nvme_ctrl_get_by_path() Message-ID: <20191009221344.GB3009@washi1.fujisawa.hgst.com> References: <20191009192530.13079-1-logang@deltatee.com> <20191009192530.13079-2-logang@deltatee.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191009192530.13079-2-logang@deltatee.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191009_151348_312095_E56EA9E4 X-CRM114-Status: GOOD ( 11.94 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Sagi Grimberg , Chaitanya Kulkarni , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Stephen Bates , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Max Gurtovoy , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Oct 09, 2019 at 01:25:18PM -0600, Logan Gunthorpe wrote: > nvme_ctrl_get_by_path() is analagous to blkdev_get_by_path() except it > gets a struct nvme_ctrl from the path to its char dev (/dev/nvme0). > It makes use of filp_open() to open the file and uses the private > data to obtain a pointer to the struct nvme_ctrl. If the fops of the > file do not match, -EINVAL is returned. > > The purpose of this function is to support NVMe-OF target passthru. > > Signed-off-by: Logan Gunthorpe > Reviewed-by: Max Gurtovoy > Reviewed-by: Sagi Grimberg Looks fine. Reviewed-by: Keith Busch _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme