From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F9EFC4360C for ; Thu, 10 Oct 2019 13:56:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E18E6208C3 for ; Thu, 10 Oct 2019 13:56:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qJbL6is8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E18E6208C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Qrax5O6DXJgM+XoAZos+eo+JHrdUw7ht4aReSzdtRDM=; b=qJbL6is8q3Pl19 dlsF7a/VOHgBfMPemkzsMnlyi+e2TyOF26L1HOYF8vU6JSarA56Q5JThoQ34aQP56N9/K0/QcwoaC DsvEIv/GO9pC4quJbIAIahtF1mdMmV329LwFYNQY1t/b2DjKJiChUwxIrOLQ96AeLpBsw7ozLiEnD latc3Y6oPywlBBXDKUVkEIzhMdBWVCgdhCOeOEhuEuAF42hOQ9Y8LgczPjxMkLBxN+UeFY+YUgk4j q7H2dSPHa3E63l5Isv9fByeiDKlCHIGSR0nfPJGYWi+YuebPeA2iqMcLG4+z6Qu9Ckm6IhHY3m5gr BFGkSEOn9ItRzc8pIn+A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIYw4-0002QG-V4; Thu, 10 Oct 2019 13:56:56 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIYw0-0002OZ-Oi for linux-nvme@lists.infradead.org; Thu, 10 Oct 2019 13:56:55 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 09DC568C65; Thu, 10 Oct 2019 15:56:50 +0200 (CEST) Date: Thu, 10 Oct 2019 15:56:49 +0200 From: Christoph Hellwig To: Max Gurtovoy Subject: Re: [PATCH 8/8] nvme-tcp: fix possible leakage during error flow Message-ID: <20191010135649.GF31487@lst.de> References: <1570714100-15520-1-git-send-email-maxg@mellanox.com> <1570714100-15520-9-git-send-email-maxg@mellanox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1570714100-15520-9-git-send-email-maxg@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191010_065652_966632_B29A9A3E X-CRM114-Status: UNSURE ( 6.30 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sagi@grimberg.me, israelr@mellanox.com, james.smart@broadcom.com, linux-nvme@lists.infradead.org, shlomin@mellanox.com, kbusch@kernel.org, hch@lst.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Oct 10, 2019 at 04:28:20PM +0300, Max Gurtovoy wrote: > During nvme_tcp_setup_cmd_pdu error flow, one must call nvme_cleanup_cmd > since it's symmetric to nvme_setup_cmd. > > Signed-off-by: Max Gurtovoy Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme