From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59B3EC10F14 for ; Thu, 10 Oct 2019 16:18:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27ECD2067B for ; Thu, 10 Oct 2019 16:18:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dos1Ne9+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27ECD2067B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=klv6HVACDM8xgZpBsNPyExI9dwWBMjo9GXbqWCYkluY=; b=dos1Ne9+KAjHyW 0ueKUfkqtFVbWaDfjVlyDPONnoH0dMZAEEY0d7PmZ4ikGpkVLGDgQjRiHWzx+vg+pvwxkdxxSwclg 6MOAq06TBiX14BTY0JEh5iA7YsZVQczbgVWMxTprjSKrVsHXa7rBT2201LsbL7zfQVqn+EwFTCIIq yX8VCxVTbEgQIMahNY2QOdqGLTyfMTOv404m3PQsPjOYq7LhUOEhMXqtdOrof+lL6WW86mwand8hO CuorXu7BPkbTwca3xpOY9Uoov/MWqYOz+hWB/WbXWPbmfMfNQQa2gj4QA0Vi7XOjxU2yWGfAMYTWa DhjWMpuhNC6GBNxpPIrA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIb9T-00081f-HU; Thu, 10 Oct 2019 16:18:55 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIb9Q-00081H-Ca for linux-nvme@lists.infradead.org; Thu, 10 Oct 2019 16:18:54 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id A33CB68C7B; Thu, 10 Oct 2019 18:18:47 +0200 (CEST) Date: Thu, 10 Oct 2019 18:18:47 +0200 From: Christoph Hellwig To: Keith Busch Subject: Re: [PATCHv3 5/5] nvme: Wait for reset state when required Message-ID: <20191010161847.GA1942@lst.de> References: <20191010160527.22376-1-kbusch@kernel.org> <20191010160527.22376-6-kbusch@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191010160527.22376-6-kbusch@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191010_091853_844600_A22729BD X-CRM114-Status: UNSURE ( 9.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagi Grimberg , James Smart , linux-nvme@lists.infradead.org, Edmund Nadolski , Judy Brock , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Archived-At: List-Archive: > +int nvme_reset_schedule(struct nvme_ctrl *ctrl) > { > if (ctrl->state != NVME_CTRL_RESETTING) > return -EBUSY; > @@ -133,6 +133,7 @@ static int nvme_reset_schedule(struct nvme_ctrl *ctrl) > return -EBUSY; > return 0; > } > +EXPORT_SYMBOL_GPL(nvme_reset_schedule); Oh well, forgot we grow more users later. The naming of the thing still puzlles me, though. Maybe something like nvme_schedule_reset_work is a little better? Not that I'm fully happy with that either. > static void nvme_reset_done(struct pci_dev *pdev) > { > struct nvme_dev *dev = pci_get_drvdata(pdev); > - nvme_reset_ctrl_sync(&dev->ctrl); > + > + if (!nvme_reset_schedule(&dev->ctrl)) > + flush_work(&dev->ctrl.reset_work); Do we need a comment on the flush? _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme