From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Judy Brock <judy.brock@samsung.com>,
Edmund Nadolski <edmund.nadolski@intel.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org,
James Smart <james.smart@broadcom.com>
Subject: Re: [PATCHv3 5/5] nvme: Wait for reset state when required
Date: Fri, 11 Oct 2019 01:30:34 +0900
Message-ID: <20191010163034.GA22635@washi1.fujisawa.hgst.com> (raw)
In-Reply-To: <20191010161847.GA1942@lst.de>
On Thu, Oct 10, 2019 at 06:18:47PM +0200, Christoph Hellwig wrote:
> > +int nvme_reset_schedule(struct nvme_ctrl *ctrl)
> > {
> > if (ctrl->state != NVME_CTRL_RESETTING)
> > return -EBUSY;
> > @@ -133,6 +133,7 @@ static int nvme_reset_schedule(struct nvme_ctrl *ctrl)
> > return -EBUSY;
> > return 0;
> > }
> > +EXPORT_SYMBOL_GPL(nvme_reset_schedule);
>
> Oh well, forgot we grow more users later. The naming of the thing
> still puzlles me, though. Maybe something like nvme_schedule_reset_work
> is a little better? Not that I'm fully happy with that either.
I'm struggling to discover the right name here. Something like
nvme_schedule_reset_work_if_resetting() really captures it, but is a
bit verbose. Maybe nvme_try_sched_reset_work()?
> > static void nvme_reset_done(struct pci_dev *pdev)
> > {
> > struct nvme_dev *dev = pci_get_drvdata(pdev);
> > - nvme_reset_ctrl_sync(&dev->ctrl);
> > +
> > + if (!nvme_reset_schedule(&dev->ctrl))
> > + flush_work(&dev->ctrl.reset_work);
>
> Do we need a comment on the flush?
Will do.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply index
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 16:05 [PATCHv3 0/5] nvme: double reset prevention Keith Busch
2019-10-10 16:05 ` [PATCHv3 1/5] nvme-pci: Free tagset if no IO queues Keith Busch
2019-10-10 16:05 ` [PATCHv3 2/5] nvme: Remove ADMIN_ONLY state Keith Busch
2019-10-10 16:05 ` [PATCHv3 3/5] nvme: Restart request timers in resetting state Keith Busch
2019-10-10 16:05 ` [PATCHv3 4/5] nvme: Prevent resets during paused controller state Keith Busch
2019-10-10 16:09 ` Christoph Hellwig
2019-10-10 16:17 ` Keith Busch
2019-10-10 16:05 ` [PATCHv3 5/5] nvme: Wait for reset state when required Keith Busch
2019-10-10 16:18 ` Christoph Hellwig
2019-10-10 16:30 ` Keith Busch [this message]
Reply instructions:
You may reply publically to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010163034.GA22635@washi1.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=edmund.nadolski@intel.com \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=judy.brock@samsung.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-NVME Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-nvme/0 linux-nvme/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-nvme linux-nvme/ https://lore.kernel.org/linux-nvme \
linux-nvme@lists.infradead.org linux-nvme@archiver.kernel.org
public-inbox-index linux-nvme
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.infradead.lists.linux-nvme
AGPL code for this site: git clone https://public-inbox.org/ public-inbox