Linux-NVME Archive on lore.kernel.org
 help / color / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Jeffrey Lien <Jeff.Lien@wdc.com>
Cc: linux-nvme <linux-nvme@lists.infradead.org>
Subject: Re: Issue With NVME CLI list Command
Date: Fri, 11 Oct 2019 04:39:20 +0900
Message-ID: <20191010193920.GC22635@washi1.fujisawa.hgst.com> (raw)
In-Reply-To: <20191010192318.GB22635@washi1.fujisawa.hgst.com>

On Fri, Oct 11, 2019 at 04:23:18AM +0900, Keith Busch wrote:
> On Thu, Oct 10, 2019 at 07:11:10PM +0000, Jeffrey Lien wrote:
> > Keith, 
> > I'm getting a "Failed to scan namespaces" error message back from the
> > "nvme list" command after updating my fork and picking up your changes
> > from Aug 28th.  The cause of the failure is the following check in the
> > function verify_legacy_ns (in nvme-topology.c):
> > 
> > 	if (memcmp(id.mn, c->id.mn, sizeof(id.mn)) ||
> > 	    memcmp(id.sn, c->id.mn, sizeof(id.sn)))
> > 		return -ENODEV;
> > 
> > The problem I see is that ctrl info is never filled in (at least in my
> > case).  Both c->id.mn and c->id.sn are blank.  Looking back in the
> > legacy_list function, I don't see how the ctrl info is ever filled in.
> > Maybe it's just something strange in my case; I would have thought
> > someone would have stumbled across already but maybe not.  If I remove
> > the above check; everything seems to work so I think the code is
> > basically working as expected.    Could you review the changes and
> > either confirm what I'm seeing or let me know if I'm missing
> > something.  
> 
> Hi Jeff,
> 
> What kernel version are you using?

Oops, nevermind, there was a couple bugs in that path. The controller
needed to be initialized before scanning the namespaces, and then we
need to compare the correct fields. Fixed now:

  https://github.com/linux-nvme/nvme-cli/commit/1e858be6c25172f9946e4979ee724244bdd722b2

Thanks for the notice.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-10 19:11 Jeffrey Lien
2019-10-10 19:23 ` Keith Busch
2019-10-10 19:39   ` Keith Busch [this message]
2019-10-10 20:10     ` Jeffrey Lien
2019-10-10 19:42   ` Jeffrey Lien

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191010193920.GC22635@washi1.fujisawa.hgst.com \
    --to=kbusch@kernel.org \
    --cc=Jeff.Lien@wdc.com \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NVME Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-nvme/0 linux-nvme/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvme linux-nvme/ https://lore.kernel.org/linux-nvme \
		linux-nvme@lists.infradead.org
	public-inbox-index linux-nvme

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-nvme


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git