From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B22D0C4360C for ; Thu, 10 Oct 2019 19:39:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CA94206A1 for ; Thu, 10 Oct 2019 19:39:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aDzF5sct"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="YzuoIlpY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CA94206A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uJH83LpV/78bGwYwxvUJ0V95TEc2951AwIZ8LR5XEHE=; b=aDzF5sctUQTWsy IAPmKSJgYt5EETQ29BAgF491Qr4Od6YGx1IoRh0AKByzJMBGsfAVcWVZLv23ZW2/VCkl7DwqEUUEG Xz1xGwSgbxyiucP8AWAlOkT09uxIXFVOGE/ly22HBdm1ZPzIw+DGuWckqFKGLKgyPf/mZFVmbUQzN 1Ck4NjisMwUeAwR1jTN7aFPG/XfwifHd5OzfTSuPlQG0sCB2MN9nooxkdDqznD+CGk358NbgBTZ5+ h15E7T/nsKWronN9hFSCs36zub5x9LVF9E/tIQ+Ijc6XNPYmGgCUISdMKjyblyAIbdY2d4WCSPZ9n hZpnCL+AcXxZJ9McF2xQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIeHX-0003rx-62; Thu, 10 Oct 2019 19:39:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIeHT-0003rc-Pd for linux-nvme@lists.infradead.org; Thu, 10 Oct 2019 19:39:25 +0000 Received: from washi1.fujisawa.hgst.com (unknown [199.255.47.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E3DBB206A1; Thu, 10 Oct 2019 19:39:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570736363; bh=dLcX7noLUDJl05YpwB38Hz5/kRcDCtCF2DvEycAZ83Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YzuoIlpYzjWnhFO3Pdq3I0Y58kDf7xt6xFKexgazmnxPGKzFbFcomFkFFj8Rqg7yw ylzGQQkfmZwMZ+PesCwNhOGRkQhutAe8L88CxHnAdeqs6nBWp8uNcNExj49A6lLSgT VohyBCJgCPGA2Lc5n0YXhTdGbZijLipRC41ftoic= Date: Fri, 11 Oct 2019 04:39:20 +0900 From: Keith Busch To: Jeffrey Lien Subject: Re: Issue With NVME CLI list Command Message-ID: <20191010193920.GC22635@washi1.fujisawa.hgst.com> References: <20191010192318.GB22635@washi1.fujisawa.hgst.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191010192318.GB22635@washi1.fujisawa.hgst.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191010_123923_852694_11D6AC26 X-CRM114-Status: GOOD ( 17.58 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-nvme Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, Oct 11, 2019 at 04:23:18AM +0900, Keith Busch wrote: > On Thu, Oct 10, 2019 at 07:11:10PM +0000, Jeffrey Lien wrote: > > Keith, > > I'm getting a "Failed to scan namespaces" error message back from the > > "nvme list" command after updating my fork and picking up your changes > > from Aug 28th. The cause of the failure is the following check in the > > function verify_legacy_ns (in nvme-topology.c): > > > > if (memcmp(id.mn, c->id.mn, sizeof(id.mn)) || > > memcmp(id.sn, c->id.mn, sizeof(id.sn))) > > return -ENODEV; > > > > The problem I see is that ctrl info is never filled in (at least in my > > case). Both c->id.mn and c->id.sn are blank. Looking back in the > > legacy_list function, I don't see how the ctrl info is ever filled in. > > Maybe it's just something strange in my case; I would have thought > > someone would have stumbled across already but maybe not. If I remove > > the above check; everything seems to work so I think the code is > > basically working as expected. Could you review the changes and > > either confirm what I'm seeing or let me know if I'm missing > > something. > > Hi Jeff, > > What kernel version are you using? Oops, nevermind, there was a couple bugs in that path. The controller needed to be initialized before scanning the namespaces, and then we need to compare the correct fields. Fixed now: https://github.com/linux-nvme/nvme-cli/commit/1e858be6c25172f9946e4979ee724244bdd722b2 Thanks for the notice. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme