From: Keith Busch <kbusch@kernel.org>
To: "Nadolski, Edmund" <edmund.nadolski@intel.com>
Cc: James Smart <james.smart@broadcom.com>,
Judy Brock <judy.brock@samsung.com>,
Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCHv4 0/5] nvme: double reset prevention
Date: Fri, 11 Oct 2019 10:27:14 -0600 [thread overview]
Message-ID: <20191011162714.GB75437@C02WT3WMHTD6.wdl.wdc.com> (raw)
In-Reply-To: <12fd3758-ff71-c02d-1545-5ce8189c2c59@intel.com>
On Fri, Oct 11, 2019 at 09:58:52AM -0600, Nadolski, Edmund wrote:
> On 10/10/2019 10:57 AM, Keith Busch wrote:
> > The main objective of this series is to prevent double resets. This sort
> > of thing is known to have happened if a timeout occurs at roughly the
> > same time as a user intiated reset, like through through PCIe's FLR.
> >
> > The double reset could happen because the controller disabling had been
> > occuring outside of the RESETTING state when we can't schedule the
> > reset_work, which is to occur later. When another reset schedules in
> > between these events, the controller ends up in the wrong state.
> >
> > The end result of this series is simply to block subsequent resets by
> > initializing the controller state to RESETTING without actually scheduling
> > the reset_work.
> >
> > v3 -> v4:
> >
> > Renamed nvme_reset_schedule() to nvme_try_sched_reset_work() and
> > documented when it may fail (hot remove). I'm open to suggestions for
> > a better name.
> >
> > Keith Busch (5):
> > nvme-pci: Free tagset if no IO queues
> > nvme: Remove ADMIN_ONLY state
> > nvme: Restart request timers in resetting state
> > nvme: Prevent resets during paused controller state
> > nvme: Wait for reset state when required
> >
> > drivers/nvme/host/core.c | 91 +++++++++++++++++++++++++++----------
> > drivers/nvme/host/fabrics.h | 3 +-
> > drivers/nvme/host/nvme.h | 5 +-
> > drivers/nvme/host/pci.c | 78 ++++++++++++++++++-------------
> > drivers/nvme/host/rdma.c | 8 ++++
> > drivers/nvme/host/tcp.c | 8 ++++
> > 6 files changed, 134 insertions(+), 59 deletions(-)
> >
>
> Tested-by: Edmund Nadolski <edmund.nadolski@intel.com>
Thanks, Ed.
Christoph, any remaining concerns on this? If no, do you prefer I push
this to 5.5 or 5.4? This fixings reported bugs, but it ended up a bit
larger and later than I originally hoped, so I'm okay either way.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-10-11 16:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 16:57 [PATCHv4 0/5] nvme: double reset prevention Keith Busch
2019-10-10 16:57 ` [PATCHv4 1/5] nvme-pci: Free tagset if no IO queues Keith Busch
2019-10-10 16:57 ` [PATCHv4 2/5] nvme: Remove ADMIN_ONLY state Keith Busch
2019-10-10 16:57 ` [PATCHv4 3/5] nvme: Restart request timers in resetting state Keith Busch
2019-10-10 16:57 ` [PATCHv4 4/5] nvme: Prevent resets during paused controller state Keith Busch
2019-10-10 16:57 ` [PATCHv4 5/5] nvme: Wait for reset state when required Keith Busch
2019-10-16 0:56 ` Balbir Singh
2019-10-10 17:09 ` [PATCHv4 0/5] nvme: double reset prevention Nadolski, Edmund
2019-10-11 15:58 ` Nadolski, Edmund
2019-10-11 16:27 ` Keith Busch [this message]
2019-10-14 7:15 ` Christoph Hellwig
2019-10-14 15:06 ` Keith Busch
2019-10-14 7:14 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011162714.GB75437@C02WT3WMHTD6.wdl.wdc.com \
--to=kbusch@kernel.org \
--cc=edmund.nadolski@intel.com \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=judy.brock@samsung.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).