linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: sagi@grimberg.me, israelr@mellanox.com, james.smart@broadcom.com,
	linux-nvme@lists.infradead.org, shlomin@mellanox.com,
	kbusch@kernel.org, hch@lst.de
Subject: Re: [PATCH v2 0/8] small NVMe cleanups/fixes
Date: Mon, 14 Oct 2019 09:07:14 +0200	[thread overview]
Message-ID: <20191014070714.GA10054@lst.de> (raw)
In-Reply-To: <1570985858-26805-1-git-send-email-maxg@mellanox.com>

On Sun, Oct 13, 2019 at 07:57:30PM +0300, Max Gurtovoy wrote:
> Hi Sagi/Christoph/Keith,
> This series include few fast-path and code readability improvements from
> IsraelR and also few memleak fixes and new status code introduction from
> myself.

I'm not fully sold on the unlikely annotations, but then again don't
have a strong argument against them either.

Otherwise this looks good to me

Reviewed-by: Christoph Hellwig <hch@lst.de>

> 
> This series applies cleanly on top of nvme-5.4 branch, commit 3a8ecc935efab
> ("nvme: retain split access workaround for capability reads")

Keith has started a 5.5 branch in the meantime, but there shouldn't be
major conflicts as far as I can see.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  parent reply	other threads:[~2019-10-14  7:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-13 16:57 [PATCH v2 0/8] small NVMe cleanups/fixes Max Gurtovoy
2019-10-13 16:57 ` [PATCH 1/8] nvme: introduce nvme_is_aen_req function Max Gurtovoy
2019-10-13 16:57 ` [PATCH 2/8] nvmet: use bio_io_error instead of duplicating it Max Gurtovoy
2019-10-13 16:57 ` [PATCH 3/8] nvmet: add unlikely check at nvmet_req_alloc_sgl Max Gurtovoy
2019-10-13 16:57 ` [PATCH 4/8] nvmet-rdma: add unlikely check at nvmet_rdma_map_sgl_keyed Max Gurtovoy
2019-10-13 16:57 ` [PATCH 5/8] nvme: introduce "Command Aborted By host" status code Max Gurtovoy
2019-10-13 16:57 ` [PATCH 6/8] nvme: move common call to nvme_cleanup_cmd to core layer Max Gurtovoy
2019-10-13 16:57 ` [PATCH 7/8] nvmet-loop: fix possible leakage during error flow Max Gurtovoy
2019-10-14 15:32   ` Keith Busch
2019-10-13 16:57 ` [PATCH 8/8] nvme-tcp: " Max Gurtovoy
2019-10-14  7:07 ` Christoph Hellwig [this message]
2019-10-14 15:05 ` [PATCH v2 0/8] small NVMe cleanups/fixes Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191014070714.GA10054@lst.de \
    --to=hch@lst.de \
    --cc=israelr@mellanox.com \
    --cc=james.smart@broadcom.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=maxg@mellanox.com \
    --cc=sagi@grimberg.me \
    --cc=shlomin@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).