From: Kevin Hao <haokexin@gmail.com>
To: Keith Busch <kbusch@kernel.org>
Cc: Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH] nvme-pci: Set the prp2 correctly when using more than 4k page
Date: Fri, 18 Oct 2019 08:59:26 +0800 [thread overview]
Message-ID: <20191018005926.GN27363@pek-khao-d2.corp.ad.wrs.com> (raw)
In-Reply-To: <20191017173807.GA91017@C02WT3WMHTD6>
[-- Attachment #1.1: Type: text/plain, Size: 426 bytes --]
On Thu, Oct 17, 2019 at 11:38:07AM -0600, Keith Busch wrote:
> On 10/17/19, 1:40 AM, "Kevin Hao" <haokexin@gmail.com> wrote:
> > + unsigned int offset = bv->bv_offset % dev->ctrl.page_size;
>
> Can we do this without the modulo in the io path? The page_size is a power of
> 2, so this should work:
>
> unsigned int offset = bv->bv_offset & (dev->ctrl.page_size - 1);
Sure. V2 is coming soon.
Thanks,
Kevin
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 158 bytes --]
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-10-18 0:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 7:34 [PATCH] nvme-pci: Set the prp2 correctly when using more than 4k page Kevin Hao
2019-10-17 14:55 ` Christoph Hellwig
2019-10-17 17:38 ` Keith Busch
2019-10-18 0:59 ` Kevin Hao [this message]
2019-10-18 2:53 ` [PATCH v2] " Kevin Hao
2019-10-18 6:48 ` Christoph Hellwig
2019-10-18 14:10 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018005926.GN27363@pek-khao-d2.corp.ad.wrs.com \
--to=haokexin@gmail.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).