linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Anton Eidelman <anton@lightbitslabs.com>
Cc: keith.busch@intel.com, hare@suse.de, hch@lst.de,
	linux-nvme@lists.infradead.org, sagi@grimberg.me
Subject: Re: [PATCH] nvme-multipath: fix possible io hang after ctrl reconnect
Date: Fri, 18 Oct 2019 11:10:16 +0200	[thread overview]
Message-ID: <20191018091016.GA25478@lst.de> (raw)
In-Reply-To: <20191017181142.28524-1-anton@lightbitslabs.com>

On Thu, Oct 17, 2019 at 11:11:42AM -0700, Anton Eidelman wrote:
> As far as I can see nvme_init_identify() is called from
> nvme_xxx_configure_admin_queue() in tcp.c as well as in rdma.c
> regardless of the value of "new".
> This makes sense as over reconnect things in the identify might change
> for a dynamic controller, e.g. the cntlid.

True.  I guess the patch is fine, but please remove the now dead
groups_only code.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2019-10-18  9:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-15 17:08 [PATCH] nvme-multipath: fix possible io hang after ctrl reconnect Anton Eidelman
2019-10-17  7:03 ` Hannes Reinecke
2019-10-17 15:22 ` Christoph Hellwig
2019-10-17 18:11   ` Anton Eidelman
2019-10-18  9:10     ` Christoph Hellwig [this message]
2019-10-18 18:32       ` [PATCH v2 1/2] " Anton Eidelman
2019-10-18 18:32         ` [PATCH v2 2/2] nvme-multipath: remove unused groups_only mode in ana log Anton Eidelman
2019-10-22 19:48           ` Sagi Grimberg
2019-10-22 19:48         ` [PATCH v2 1/2] nvme-multipath: fix possible io hang after ctrl reconnect Sagi Grimberg
2019-10-23  1:18           ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191018091016.GA25478@lst.de \
    --to=hch@lst.de \
    --cc=anton@lightbitslabs.com \
    --cc=hare@suse.de \
    --cc=keith.busch@intel.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).