From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8824ECA9EA1 for ; Fri, 18 Oct 2019 09:10:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A290222BD for ; Fri, 18 Oct 2019 09:10:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DRCXVo58" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A290222BD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9es4DbW24elPMp328Bg7vY/vODxFYUcMIAA5RbTFxbY=; b=DRCXVo58lQMich HJwOPDNg0bfTWHujINrTMUnAR6zGEmejAWtaE2COsIOGgzOaeXErXnpj1sjORKvPD+hKfRN9EMlsK g74c/zfnmxVIDyVk1q3CZMQrjhujVEgfdTPsHU7Z5nZB0HufVffBrEw74pgxOTr4qWlc5nzt9lDFX xWC83ilXTkPx4V4kGzB/nRTqqMqVnCO5QuYEHiLxMiHlfKuuQZqaCdVIfw9mOe9UGxzIZsaTZ4O8S PehdwsnTjj1wvB/ho97kU+nY4mEueDj7JVjjrKy+UVnHPZKE2sOn9E2jvs0UDa8vWIvfvoW02Vq9j /fBalQ3JOAuvUGytf5GQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLOHA-000856-FY; Fri, 18 Oct 2019 09:10:24 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLOH7-00084P-1D for linux-nvme@lists.infradead.org; Fri, 18 Oct 2019 09:10:22 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id BA1F768BE1; Fri, 18 Oct 2019 11:10:16 +0200 (CEST) Date: Fri, 18 Oct 2019 11:10:16 +0200 From: Christoph Hellwig To: Anton Eidelman Subject: Re: [PATCH] nvme-multipath: fix possible io hang after ctrl reconnect Message-ID: <20191018091016.GA25478@lst.de> References: <20191017152241.GA9155@lst.de> <20191017181142.28524-1-anton@lightbitslabs.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191017181142.28524-1-anton@lightbitslabs.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191018_021021_231665_701AB126 X-CRM114-Status: UNSURE ( 9.04 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: keith.busch@intel.com, hare@suse.de, hch@lst.de, linux-nvme@lists.infradead.org, sagi@grimberg.me Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Oct 17, 2019 at 11:11:42AM -0700, Anton Eidelman wrote: > As far as I can see nvme_init_identify() is called from > nvme_xxx_configure_admin_queue() in tcp.c as well as in rdma.c > regardless of the value of "new". > This makes sense as over reconnect things in the identify might change > for a dynamic controller, e.g. the cntlid. True. I guess the patch is fine, but please remove the now dead groups_only code. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme