From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36921CA9EAC for ; Mon, 21 Oct 2019 03:44:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A331E21928 for ; Mon, 21 Oct 2019 03:44:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XD+4KR5O" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A331E21928 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5LAipjy2wd3dXRnwkhzmPwe6jUEUZcvNNNUXag5w73Y=; b=XD+4KR5Ol35o56 otWc3ppUO14wYssb9dcLxOOaQmnQgCcX3r251rNii9gkZTDQ1XHHj3xd3kzuGKbRtjemy2kSIb6Rd wmc1BJaIJLBgmFEGE1z3egN683PwQf9Y5KN2j7sSEITw51SvC8EIKdto0p1SvlpX2Fwd3uKZv7q5g Tg0Rira8dF243+eRvnA2+4fhcrWQjlNkSsCRt30XJO5lCkcYV4dvGuf2gzw424ArldgA86EZd/ucG 8glI9YD7mr3uAgqsj5ub7TDEuWL2HXx0Xbp1MruDh/iRsJecvRxIE7LBSnDkjjRB9FgBkdC1hRiCW PBxzUwdaMIBIl6hGzJgA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMOcQ-0006tV-Fb; Mon, 21 Oct 2019 03:44:30 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMOcM-0006oO-6e for linux-nvme@lists.infradead.org; Mon, 21 Oct 2019 03:44:27 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 3754368BFE; Mon, 21 Oct 2019 05:44:24 +0200 (CEST) Date: Mon, 21 Oct 2019 05:44:24 +0200 From: Christoph Hellwig To: Damien Le Moal Subject: Re: [PATCH 1/2 v2] nvme: Cleanup and rename nvme_block_nr() Message-ID: <20191021034424.GB11888@lst.de> References: <20191021034004.11063-1-damien.lemoal@wdc.com> <20191021034004.11063-2-damien.lemoal@wdc.com> <20191021034414.GA11888@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191021034414.GA11888@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191020_204426_405391_7CE423D7 X-CRM114-Status: UNSURE ( 9.24 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, Keith Busch , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Oct 21, 2019 at 05:44:14AM +0200, Christoph Hellwig wrote: > On Mon, Oct 21, 2019 at 12:40:03PM +0900, Damien Le Moal wrote: > > Rename nvme_block_nr() to nvme_sect_to_lba() and use SECTOR_SHIFT > > instead of its hard coded value 9. Also add a comment to decribe this > > helper. > > > > Signed-off-by: Damien Le Moal > > Looks fine, > > Reviewed-by: Christoph Hellwig Looks fine, Reviewed-by: Christoph Hellwig _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme