* [PATCH] nvmet: fill discovery controller sn, fr and mn correctly
@ 2019-10-24 16:55 Sagi Grimberg
2019-10-25 0:19 ` Keith Busch
2019-10-27 15:16 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Sagi Grimberg @ 2019-10-24 16:55 UTC (permalink / raw)
To: linux-nvme; +Cc: Keith Busch, Christoph Hellwig
Discovery controllers need this information as well.
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
---
drivers/nvme/target/discovery.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/target/discovery.c b/drivers/nvme/target/discovery.c
index 3764a8900850..63994787e2ca 100644
--- a/drivers/nvme/target/discovery.c
+++ b/drivers/nvme/target/discovery.c
@@ -231,6 +231,7 @@ static void nvmet_execute_identify_disc_ctrl(struct nvmet_req *req)
{
struct nvmet_ctrl *ctrl = req->sq->ctrl;
struct nvme_id_ctrl *id;
+ const char model[] = "Linux";
u16 status = 0;
id = kzalloc(sizeof(*id), GFP_KERNEL);
@@ -239,8 +240,13 @@ static void nvmet_execute_identify_disc_ctrl(struct nvmet_req *req)
goto out;
}
+ memset(id->sn, ' ', sizeof(id->sn));
+ bin2hex(id->sn, &ctrl->subsys->serial,
+ min(sizeof(ctrl->subsys->serial), sizeof(id->sn) / 2));
memset(id->fr, ' ', sizeof(id->fr));
- strncpy((char *)id->fr, UTS_RELEASE, sizeof(id->fr));
+ memcpy_and_pad(id->mn, sizeof(id->mn), model, sizeof(model) - 1, ' ');
+ memcpy_and_pad(id->fr, sizeof(id->fr),
+ UTS_RELEASE, strlen(UTS_RELEASE), ' ');
/* no limit on data transfer sizes for now */
id->mdts = 0;
--
2.20.1
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvmet: fill discovery controller sn, fr and mn correctly
2019-10-24 16:55 [PATCH] nvmet: fill discovery controller sn, fr and mn correctly Sagi Grimberg
@ 2019-10-25 0:19 ` Keith Busch
2019-10-27 15:16 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Keith Busch @ 2019-10-25 0:19 UTC (permalink / raw)
To: Sagi Grimberg; +Cc: Christoph Hellwig, linux-nvme
Thanks, applied to nvme-5.5.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvmet: fill discovery controller sn, fr and mn correctly
2019-10-24 16:55 [PATCH] nvmet: fill discovery controller sn, fr and mn correctly Sagi Grimberg
2019-10-25 0:19 ` Keith Busch
@ 2019-10-27 15:16 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2019-10-27 15:16 UTC (permalink / raw)
To: Sagi Grimberg; +Cc: Keith Busch, Christoph Hellwig, linux-nvme
On Thu, Oct 24, 2019 at 09:55:58AM -0700, Sagi Grimberg wrote:
> Discovery controllers need this information as well.
Can we please lift that code into a common helper? Especially with
the desire to make the information configurable.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-27 15:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-24 16:55 [PATCH] nvmet: fill discovery controller sn, fr and mn correctly Sagi Grimberg
2019-10-25 0:19 ` Keith Busch
2019-10-27 15:16 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).