From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DB9DCA9EA0 for ; Mon, 28 Oct 2019 08:09:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E15BA20B7C for ; Mon, 28 Oct 2019 08:09:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m2t8Zd6q"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Av5WlIuL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E15BA20B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zuyCULUrMQjpPA7qwPZE+h3XwMx7XVgStbG+PQelTtY=; b=m2t8Zd6qbEg7g2 R9orFHFVHavWZaX3AVObOQzket/BNFdMil+eyh1cV0nHomayGXmPGN09pHxl7KvFjTl8P0OYMb2BV /EMgW01ZlnrApOIz0K8j8FUegOCA5nN5Z+1B5iKTQe3rj4dDk8hWeUogWZ9GfRoaAmJewAnYG6Rtz O1cykukycrAivdNvg9FLARP6X5IRUXFDq/svLPyOwQp8uMWdmQXW4RRrDU5EosG4bHjo5zis3Y0i+ nELZFNQaVnogBVF5X6nuyMwNsfCjcCA1Lu1ZenOu9scO14PD+opuYw8GVXkoxF2LjzrqxL78fJpUL llIiGRxVQl+LPGbj7u3A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iP05I-0001on-CE; Mon, 28 Oct 2019 08:09:04 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iP05G-0001oQ-Fw for linux-nvme@lists.infradead.org; Mon, 28 Oct 2019 08:09:03 +0000 Received: from redsun51.ssa.fujisawa.hgst.com (unknown [199.255.47.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E8E6420862; Mon, 28 Oct 2019 08:09:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572250142; bh=LlIrMK4H2FX/ElMC68HUSkCIrf+CSFBsfV3lLy7IFU0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Av5WlIuLfRNpYN3ggTKCRP4vYawnYNrgiql5lhXdg1WySpujaEZZLe9BpOfSo77At GPrn1l9cU48yGmVXsDDvJDiTTLZw7QCJB2pMVK76phI2d4o8hKTSDJQ8+MnxJht0BE rUTHrMIrZGxTCfo5USWWJoUNSp4t7LKXdoIdkXIc= Date: Mon, 28 Oct 2019 17:08:58 +0900 From: Keith Busch To: Christoph Hellwig Subject: Re: [PATCH] nvme: Add hardware monitoring support Message-ID: <20191028080858.GB1718@redsun51.ssa.fujisawa.hgst.com> References: <20191028024156.23964-1-linux@roeck-us.net> <20191028073953.GA20443@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191028073953.GA20443@lst.de> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191028_010902_552876_3C698DB7 X-CRM114-Status: GOOD ( 19.28 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagi Grimberg , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Akinobu Mita , Jens Axboe , Chris Healy , Guenter Roeck Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Oct 28, 2019 at 08:39:53AM +0100, Christoph Hellwig wrote: > On Sun, Oct 27, 2019 at 07:41:56PM -0700, Guenter Roeck wrote: > > nvme devices report temperature information in the controller information > > (for limits) and in the smart log. Currently, the only means to retrieve > > this information is the nvme command line interface, which requires > > super-user privileges. > > > > At the same time, it would be desirable to use NVME temperature information > > for thermal control. > > > > This patch adds support to read NVME temperatures from the kernel using the > > hwmon API and adds temperature zones for NVME drives. The thermal subsystem > > can use this information to set thermal policies, and userspace can access > > it using libsensors and/or the "sensors" command. > > So these reported values seem to generate some interest. Adding Akinobu > Mita who also planned to wire them up to the thermal framework. I don't > really know either upper layer so I'm not sure which is the right one, > but with this just like with the previous series I am quite worried that > we add a lot of kernel boilerplate code for information people can > trivially get using nvme-cli. I think it's nvme-cli requires root, where this conveniently doesn't need those elevated rights. I'm not familiar with either upper level framework either; my only review comment for this patch is to use devm_kfree() for the error cases. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme