From: Keith Busch <kbusch@kernel.org>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Cc: "axboe@fb.com" <axboe@fb.com>,
Prabhath Sajeepa <psajeepa@purestorage.com>,
Christoph Hellwig <hch@lst.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH] nvme: Fix parsing of ANA log page
Date: Thu, 31 Oct 2019 08:39:56 +0900 [thread overview]
Message-ID: <20191030233956.GA18025@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <BYAPR04MB5749C7095DA29A52C1D0336286600@BYAPR04MB5749.namprd04.prod.outlook.com>
On Wed, Oct 30, 2019 at 07:55:44PM +0000, Chaitanya Kulkarni wrote:
> On 10/30/2019 07:29 AM, Christoph Hellwig wrote:
> > The only thing this changes is that we now also execute the check
> > for the first entry parsed. But the log size should never be so small
> > for this to matter. Can you explain what problem your are trying to
> > solve?
> >
>
> I had hard time finding out that scenario.
>
> Prabhat, can you please explain ?
The scenario should only apply if the controller reports an invalid
nanagrpid of 0, which spec disallows when ANA CMIC is set. We're not
validating nanagrpid compliance though, so this "fix" should only help
with broken controller implementations.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2019-10-30 23:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 22:56 [PATCH] nvme: Fix parsing of ANA log page Prabhath Sajeepa
2019-10-29 17:15 ` Sagi Grimberg
2019-10-30 0:46 ` Keith Busch
2019-10-30 14:29 ` Christoph Hellwig
2019-10-30 19:55 ` Chaitanya Kulkarni
2019-10-30 23:39 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191030233956.GA18025@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=psajeepa@purestorage.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).