From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA7ADCA9ECB for ; Thu, 31 Oct 2019 13:46:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD94720578 for ; Thu, 31 Oct 2019 13:46:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NfmLvjPI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD94720578 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hQF6GycreV0xOscN++YGvmbepizcu98hDlSdCLkYSMo=; b=NfmLvjPIjUSd8a +PRSJIIDqr+ruUQ4o6lkGftYi0890NTs3LeGmVO4P5qVBszx7dbBMQE7srLoCx7r/cYFBc9xTYDWN HKEeHca3QeWYfqmodKNPO9V612veEf2bOOArExOVkUsIzFsQ+ASs5gmGvJKEChe4QY+Tod5RZ42MK xsyhUBPzl/7fvApzkXoEzNu1USwcxj+xvsl8Irw1t9HNk6abl9MJPPxtP7yVJhGX+hWce5baWwviM xWfiXKqHCy1srRlGWzHh7dQ8nae0387B3UdffDDs+GpTI1KjjEidJKP9vdbOJaSv22si3n/JeOhlU GyMYh9frlr1ofRwGcRHA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQAml-0001KN-Cj; Thu, 31 Oct 2019 13:46:47 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQAmj-0001Jx-1G for linux-nvme@lists.infradead.org; Thu, 31 Oct 2019 13:46:46 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id DC96E68C65; Thu, 31 Oct 2019 14:46:42 +0100 (CET) Date: Thu, 31 Oct 2019 14:46:42 +0100 From: Christoph Hellwig To: Guenter Roeck Subject: Re: [PATCH v2] nvme: Add hardware monitoring support Message-ID: <20191031134642.GC4763@lst.de> References: <20191029223214.18889-1-linux@roeck-us.net> <20191030140511.GA14252@lst.de> <2931487e-2720-fd42-fda0-e47cf89c90c9@roeck-us.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2931487e-2720-fd42-fda0-e47cf89c90c9@roeck-us.net> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191031_064645_225754_0B09F888 X-CRM114-Status: GOOD ( 11.84 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagi Grimberg , Linux PM , LKML , linux-nvme@lists.infradead.org, Akinobu Mita , Jens Axboe , Keith Busch , Christoph Hellwig , Chris Healy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Oct 30, 2019 at 07:54:47PM -0700, Guenter Roeck wrote: > On 10/30/19 7:05 AM, Christoph Hellwig wrote: >> On Wed, Oct 30, 2019 at 08:16:48PM +0900, Akinobu Mita wrote: >>> The nvme_init_identify() can be called multiple time in nvme ctrl's >>> lifetime (e.g 'nvme reset /dev/nvme*' or suspend/resume paths), so >>> should we need to prevent nvme_hwmon_init() from registering hwmon >>> device more than twice? >>> >>> In the nvme thermal zone patchset[1], thernal zone is registered in >>> nvme_init_identify and unregistered in nvme_stop_ctrl(). >> >> So Guenter said above the thermal subsystem could use the information >> from hwmon as well. Does this mean this patch would solve your needs >> as well? >> > Depends on the requirements. Unlike hwmon/iio, we don't have clear > guidelines describing when thermal vs. hwmon would be a better choice. > There is some interconnect between thermal and hwmon, but quite often > it is a one-way street (hwmon devices can easily register thermal > zones, for thermal zone devices it is a bit more difficult to register > associated hwmon devices). I'd like to hear from Akinobu-san if this also solves the thermal zone use case. If so I'd be much happier as we at least solve two use cases with one patch. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme