From: Daniel Wagner <dwagner@suse.de>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org,
jthumshirn@suse.de
Subject: Re: [PATCH] nvmet: Always remove processed AER elements from list
Date: Mon, 4 Nov 2019 09:13:38 +0100 [thread overview]
Message-ID: <20191104081338.gdrk2a4mlov2io6s@beryllium.lan> (raw)
In-Reply-To: <20191103201310.24785-1-chaitanya.kulkarni@wdc.com>
Hi Chaitanya,
On Sun, Nov 03, 2019 at 12:13:10PM -0800, Chaitanya Kulkarni wrote:
> I've added the code to loop over and clear out outstanding requests
> present in the ctrl->async_event_cmds[] for which aen is not generated.
> Also updated the patch description.
>
> I did the basic testing create/delete ctrl and enable/disable ns that
> did not produced any hands or errors.
Thanks for addressing Christoph's comment. I'll get this patch into
our customer's test setup.
> Following is the test log if anyone wants to take a look:-
>
> nvmet: adding nsid 1 to subsystem fs
> nvmet: creating controller 1 for subsystem fs for NQN \
> nqn.2014-08.org.nvmexpress:uuid:a0b58ccb-6b6a-4045-8ee1-641816bf548d.
> nvme nvme1: Please enable CONFIG_NVME_MULTIPATH for full support of multi-port devices.
> nvme nvme1: creating 12 I/O queues.
> nvme nvme1: new ctrl: "fs"
> # nvme list | tr -s ' ' ' ' | grep Linux | grep -v '\-\-\-\-'
> /dev/nvme1n1 c71f2d6a3f577a29 Linux 1 524.29 MB / 524.29 MB 1 B + 9 B 5.4.0-rc
> # cat /sys/kernel/config/nvmet/subsystems/fs/namespaces/1/enable
> 1
> # nvme list | tr -s ' ' ' ' | grep Linux | grep -v '\-\-\-\-'
> /dev/nvme1n1 c71f2d6a3f577a29 Linux 1 524.29 MB / 524.29 MB 1 B + 9 B 5.4.0-rc
> # echo 0 > /sys/kernel/config/nvmet/subsystems/fs/namespaces/1/enable
> # nvme list | tr -s ' ' ' ' | grep Linux | grep -v '\-\-\-\-'
> # echo 1 > /sys/kernel/config/nvmet/subsystems/fs/namespaces/1/enable
> # nvme list | tr -s ' ' ' ' | grep Linux | grep -v '\-\-\-\-'
> /dev/nvme1n1 c71f2d6a3f577a29 Linux 1 524.29 MB / 524.29 MB 1 B + 9 B 5.4.0-rc
> # echo 0 > /sys/kernel/config/nvmet/subsystems/fs/namespaces/1/enable
> # nvme list | tr -s ' ' ' ' | grep Linux | grep -v '\-\-\-\-'
> # echo 1 > /sys/kernel/config/nvmet/subsystems/fs/namespaces/1/enable
BTW, I got feedback how to produce the oops on our custerms setup:
Test Steps:
1. Create two targets on node n1 as target side (tgt1 and tgt2)
2. Run perf to write data to tgt2:
sudo ./perf -q 1 -w read -o 4096 -t 60 -r 'trtype:RDMA adrfam:IPv4 traddr:192.168.219.4 trsvcid:4421'
3. Deleted tgt2 node n1 configuration during perf execution
and reboot the node n1 automatically.
I hope I got the steps summerized correctly.
Thanks,
Daniel
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-11-04 8:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-03 20:13 [PATCH] nvmet: Always remove processed AER elements from list Chaitanya Kulkarni
2019-11-04 8:13 ` Daniel Wagner [this message]
2019-11-04 9:50 ` Johannes Thumshirn
2019-11-04 10:19 ` Daniel Wagner
2019-11-08 10:42 ` Daniel Wagner
2019-11-10 2:25 ` Chaitanya Kulkarni
2019-11-11 7:28 ` Daniel Wagner
2019-12-05 9:23 ` Daniel Wagner
2019-12-11 7:39 ` Chaitanya Kulkarni
2019-12-12 9:35 ` hch
2019-11-04 20:41 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104081338.gdrk2a4mlov2io6s@beryllium.lan \
--to=dwagner@suse.de \
--cc=chaitanya.kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).