From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CB99CA9EB5 for ; Mon, 4 Nov 2019 15:02:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5316F206BA for ; Mon, 4 Nov 2019 15:02:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FfIFljRE"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="UVUOo6v8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5316F206BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aOFAjGyNrRo28Pavo0Ss1lATOdkw2PrIlBP0sIxB/p4=; b=FfIFljREqEluZn er0UhjlzLZFOmW8MzATbsuEMrG2EhVCDI1UMFyhkor+xOphUUsLRugkjFSjyoniAiwhJ62HhooKrW AiYwk2C4CisxEmgjl4nP+LPGomFkvvmw5RfHmYNr1gMBEutrD7Db8Bf/9qfu/QRzN5qPhU1Z6iyjh KKDaYsL70RbnDJ2F6FJvEplTd7nIqozfD5z6lq6+DO17VxrRUBagjDrTVMoM75iJLt5zfp2bLrkB6 Cdjs2MdvWLPWqC9ALKf00mrZaKVioYDnAaghv3bAHkMzLjaNMqteytBdLV7OCYPzmp4vpaVkOJCrT OySAITPolBM+M1ulueUQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRdrl-0006VT-1I; Mon, 04 Nov 2019 15:02:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRdri-0006Ua-D7 for linux-nvme@lists.infradead.org; Mon, 04 Nov 2019 15:01:59 +0000 Received: from redsun51.ssa.fujisawa.hgst.com (unknown [199.255.47.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4D34F20656; Mon, 4 Nov 2019 15:01:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572879717; bh=Wja1Nou+3B9RfyoLJ0X5VblrpMRkzLjZwzBxYEC726g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UVUOo6v87yZZRNciSy1W9aO3L4qjP6141S7FwkM9ySR5eaddnDq6yN5nz/Vf6mtdh rLv71dWhzUp6lTR7Z0cozX9yvtaZap/fyBCVSAbwXuisIxwZHrYVvwY6V2pDBx52mo gZuIAxz+qsYGeuWg75E20qOeOSTNEaW6BUhRkgfg= Date: Tue, 5 Nov 2019 00:01:51 +0900 From: Keith Busch To: Marta Rybczynska Subject: Re: [PATCH] nvme: change nvme_passthru_cmd64's result field. Message-ID: <20191104150151.GA26808@redsun51.ssa.fujisawa.hgst.com> References: <20191031050338.12700-1-csm10495@gmail.com> <20191031133921.GA4763@lst.de> <1977598237.90293761.1572878080625.JavaMail.zimbra@kalray.eu> <871357470.90297451.1572879417091.JavaMail.zimbra@kalray.eu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <871357470.90297451.1572879417091.JavaMail.zimbra@kalray.eu> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191104_070158_460701_EDA86F40 X-CRM114-Status: GOOD ( 13.94 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagi Grimberg , Charles Machalow , linux-kernel , linux-nvme , axboe , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Nov 04, 2019 at 03:56:57PM +0100, Marta Rybczynska wrote: > ----- On 4 Nov, 2019, at 15:51, Charles Machalow csm10495@gmail.com wrote: > > > For this one yes, UAPI size changes. Though I believe this IOCTL > > hasn't been in a released Kernel yet (just RC). Technically it may be > > changeable as a fix until the next Kernel is released. I do think its > > a useful enough > > change to warrant a late fix. > > The old one is in UAPI for years. The new one is not yet, right. I'm OK > to change the new structure. To have compatibility you would have to use > the new structure (at least its size) in the user space code. This is > what you'd liek to do? Charles is proposing only to modify the recently introduced 64-bit ioctl struct without touching the existing 32 bit version. He just wanted the lower 32-bits of the 64-bit result to occupy the same space as the 32-bit ioctl's result. That space in the 64-bit version is currently occupied by an implicit struct padding. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme