From: Keith Busch <kbusch@kernel.org>
To: wenxiong@linux.vnet.ibm.com
Cc: keith.busch@intel.com, linux-nvme@lists.infradead.org,
wenxiong@us.ibm.com
Subject: Re: [PATCH] nvme-cli: improvment critical warning format
Date: Tue, 5 Nov 2019 07:57:05 +0900 [thread overview]
Message-ID: <20191104225705.GB21282@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <1572895699-3096-1-git-send-email-wenxiong@linux.vnet.ibm.com>
On Mon, Nov 04, 2019 at 01:28:19PM -0600, wenxiong@linux.vnet.ibm.com wrote:
> + json_object_add_value_int(root," [0:0]:Available Spare", smart->critical_warning & 0x01);
> + json_object_add_value_int(root," [1:1]:Temp. Threshold", (smart->critical_warning & 0x02) >> 1);
> + json_object_add_value_int(root," [2:2]:NVM subsystem Reliability", (smart->critical_warning & 0x04) >> 2);
> + json_object_add_value_int(root," [3:3]:Read-only", (smart->critical_warning & 0x08) >> 3);
> + json_object_add_value_int(root," [4:4]:Volatile mem. backup failed", (smart->critical_warning & 0x10) >> 4);
> + json_object_add_value_int(root," [5:5]:Persistent Mem. RO", (smart->critical_warning & 0x20) >> 5);
That doesn't look like a very friendly json field name. Isn't the ':' a
special character?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-11-04 22:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 19:28 [PATCH] nvme-cli: improvment critical warning format wenxiong
2019-11-04 22:57 ` Keith Busch [this message]
2020-01-08 17:39 wenxiong
2020-01-08 20:29 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104225705.GB21282@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-nvme@lists.infradead.org \
--cc=wenxiong@linux.vnet.ibm.com \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).