From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D06CAC5DF60 for ; Tue, 5 Nov 2019 17:50:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8618217F4 for ; Tue, 5 Nov 2019 17:50:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cs1wznPn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8618217F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TCimUyIdANn2eVZZQzSqkr7iqQmI0P8FmouGHdA865A=; b=cs1wznPn+hJ26F PCzPaKhQkoM67vaY7fzQ64R+poO31KAmqZjWU4cFUIRg0dERBZKGx1FB09oVQ+VpMrxAoukhS0Btt 5lpyIzdJ/vBZc0/rwzcqShqSroyCbFBxqyys0bkv3V6T1jmM6o9UFZLwbcPqM+w4hSqn+4efRsKqB G6xDB4DuvfDImaAynyqieqzHCgVqcrFlWFhzk8yDyuPFUjtaa8PJf7yXLruiZhmcMEjV0hOJU60TH wjWlRWHFjaX8iPYUCfR+2yC9LWgSyUfSC2MP9T1RvhfateEmkI1xJVA+x0sFTj/Plk0boerSgoTju lmCLciTSAgPnjKfgC1mQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iS2yi-0003rP-Lm; Tue, 05 Nov 2019 17:50:52 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iS2yg-0003qk-2X for linux-nvme@lists.infradead.org; Tue, 05 Nov 2019 17:50:51 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 3AD0B68AFE; Tue, 5 Nov 2019 18:50:48 +0100 (CET) Date: Tue, 5 Nov 2019 18:50:48 +0100 From: Christoph Hellwig To: Max Gurtovoy Subject: Re: [PATCH 04/15] nvme: Inline nvme_ns_has_pi function Message-ID: <20191105175047.GC18972@lst.de> References: <20191105162026.183901-1-maxg@mellanox.com> <20191105162026.183901-6-maxg@mellanox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191105162026.183901-6-maxg@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191105_095050_270155_BA722807 X-CRM114-Status: GOOD ( 12.15 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sagi@grimberg.me, vladimirk@mellanox.com, idanb@mellanox.com, israelr@mellanox.com, linux-nvme@lists.infradead.org, shlomin@mellanox.com, oren@mellanox.com, kbusch@kernel.org, hch@lst.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Nov 05, 2019 at 06:20:15PM +0200, Max Gurtovoy wrote: > This function will be used by transports that support metadata/T10-PI > mechanism. > > Suggested-by: Christoph Hellwig > Signed-off-by: Max Gurtovoy > --- > drivers/nvme/host/core.c | 6 ------ > drivers/nvme/host/nvme.h | 6 ++++++ > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index 9ec8322..6f51471 100644 > --- a/drivers/nvme/host/core.c > +++ b/drivers/nvme/host/core.c > @@ -18,7 +18,6 @@ > #include > #include > #include > -#include > #include > #include > > @@ -194,11 +193,6 @@ static int nvme_delete_ctrl_sync(struct nvme_ctrl *ctrl) > return ret; > } > > -static inline bool nvme_ns_has_pi(struct nvme_ns *ns) > -{ > - return ns->pi_type && ns->ms == sizeof(struct t10_pi_tuple); > -} I'd rather add a flag. Maybe we can just add a features field in struct nvme_ns, and then set one bit for metadata supported, one for extended lbas, one for PI supported. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme