From: Christoph Hellwig <hch@lst.de> To: Max Gurtovoy <maxg@mellanox.com> Cc: sagi@grimberg.me, vladimirk@mellanox.com, idanb@mellanox.com, israelr@mellanox.com, linux-nvme@lists.infradead.org, shlomin@mellanox.com, oren@mellanox.com, kbusch@kernel.org, hch@lst.de Subject: Re: [PATCH 05/15] nvme-rdma: Add metadata/T10-PI support Date: Tue, 5 Nov 2019 18:58:12 +0100 Message-ID: <20191105175812.GE18972@lst.de> (raw) In-Reply-To: <20191105162026.183901-7-maxg@mellanox.com> On Tue, Nov 05, 2019 at 06:20:16PM +0200, Max Gurtovoy wrote: > For capable HCAs (e.g. ConnectX-4/ConnectX-5) this will allow end-to-end > protection information passthrough and validation for NVMe over RDMA > transport. Metadata offload support was implemented over the new RDMA > signature verbs API and it is enabled per controller by using nvme-cli. > > usage example: > nvme connect --pi_enable --transport=rdma --traddr=10.0.1.1 --nqn=test-nvme > > Signed-off-by: Max Gurtovoy <maxg@mellanox.com> > Signed-off-by: Israel Rukshin <israelr@mellanox.com> > --- > drivers/nvme/host/rdma.c | 346 ++++++++++++++++++++++++++++++++++++++++------- > 1 file changed, 298 insertions(+), 48 deletions(-) > > diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c > index 05f2dfa..16263b8 100644 > --- a/drivers/nvme/host/rdma.c > +++ b/drivers/nvme/host/rdma.c > @@ -48,6 +48,12 @@ struct nvme_rdma_qe { > u64 dma; > }; > > +struct nvme_rdma_sgl { > + int nents; > + struct sg_table sg_table; > + struct scatterlist first_sgl[SG_CHUNK_SIZE]; I think this needs some rework. Kill the first_sgl pointer, and then just set the pointer in the table to address found by pointer arithmetics behind the nvme_request in the allocation. We also have an open todo item to not actually allocate SG_CHUNK_SIZE entries, but a much smaller value like in SCSI. Also the whole switch to use struct sg_table should be a separate prep patch. > - struct sg_table sg_table; > - struct scatterlist first_sgl[]; > + /* T10-PI support */ > + bool is_protected; This is a bit of an odd variable name. Why not use_pi or something like that? Also all the new code should only be built if CONFIG_BLK_DEV_INTEGRITY is set. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply index Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-05 16:20 [PATCH 00/15] nvme-rdma/nvmet-rdma: " Max Gurtovoy 2019-11-05 16:20 ` [PATCH] nvme-cli/fabrics: Add pi_enable param to connect cmd Max Gurtovoy 2019-11-07 2:36 ` Martin K. Petersen 2019-11-07 12:02 ` Max Gurtovoy 2019-11-09 1:55 ` Martin K. Petersen 2019-11-10 9:25 ` Max Gurtovoy 2019-11-12 17:47 ` Sagi Grimberg 2019-11-12 18:14 ` James Smart 2019-11-12 18:23 ` Sagi Grimberg 2019-11-05 16:20 ` [PATCH 01/15] nvme-fabrics: allow user enabling metadata/T10-PI support Max Gurtovoy 2019-11-12 17:48 ` Sagi Grimberg 2019-11-05 16:20 ` [PATCH 02/15] nvme: Fail __nvme_revalidate_disk in case of a spec violation Max Gurtovoy 2019-11-05 17:49 ` Christoph Hellwig 2019-11-12 17:52 ` Sagi Grimberg 2019-11-05 16:20 ` [PATCH 03/15] nvme: Introduce max_integrity_segments ctrl attribute Max Gurtovoy 2019-11-05 17:49 ` Christoph Hellwig 2019-11-12 17:53 ` Sagi Grimberg 2019-11-05 16:20 ` [PATCH 04/15] nvme: Inline nvme_ns_has_pi function Max Gurtovoy 2019-11-05 17:50 ` Christoph Hellwig 2019-11-05 16:20 ` [PATCH 05/15] nvme-rdma: Add metadata/T10-PI support Max Gurtovoy 2019-11-05 17:58 ` Christoph Hellwig [this message] 2019-11-20 10:41 ` Max Gurtovoy 2019-11-12 18:22 ` Sagi Grimberg 2019-11-13 14:35 ` Max Gurtovoy 2019-11-14 23:57 ` Sagi Grimberg 2019-11-05 16:20 ` [PATCH 06/15] block: Introduce BIP_NOMAP_INTEGRITY bip_flag Max Gurtovoy 2019-11-05 17:52 ` Christoph Hellwig 2019-11-07 2:43 ` Martin K. Petersen 2019-11-07 13:29 ` Max Gurtovoy 2019-11-09 2:10 ` Martin K. Petersen 2019-11-12 10:40 ` Max Gurtovoy 2019-11-05 16:20 ` [PATCH 07/15] nvmet: Prepare metadata request Max Gurtovoy 2019-11-05 16:20 ` [PATCH 08/15] nvmet: Add metadata characteristics for a namespace Max Gurtovoy 2019-11-05 17:59 ` Christoph Hellwig 2019-11-12 18:38 ` Sagi Grimberg 2019-11-05 16:20 ` [PATCH 09/15] nvmet: Rename nvmet_rw_len to nvmet_rw_data_len Max Gurtovoy 2019-11-05 17:59 ` Christoph Hellwig 2019-11-12 18:39 ` Sagi Grimberg 2019-11-05 16:20 ` [PATCH 10/15] nvmet: Rename nvmet_check_data_len to nvmet_check_transfer_len Max Gurtovoy 2019-11-05 18:00 ` Christoph Hellwig 2019-11-12 18:43 ` Sagi Grimberg 2019-11-05 16:20 ` [PATCH 11/15] nvmet: Introduce nvmet_rw_prot_len and nvmet_ns_has_pi Max Gurtovoy 2019-11-05 18:00 ` Christoph Hellwig 2019-11-05 16:20 ` [PATCH 12/15] nvme: Add Metadata Capabilities enumerations Max Gurtovoy 2019-11-05 16:20 ` [PATCH 13/15] nvmet: Add metadata/T10-PI support Max Gurtovoy 2019-11-05 16:20 ` [PATCH 14/15] nvmet: Add metadata support for block devices Max Gurtovoy 2019-11-05 16:20 ` [PATCH 15/15] nvmet-rdma: Add metadata/T10-PI support Max Gurtovoy 2019-11-05 18:02 ` Christoph Hellwig 2019-11-07 13:43 ` Max Gurtovoy 2019-11-12 18:34 ` Sagi Grimberg 2019-11-13 13:56 ` Max Gurtovoy 2019-11-14 23:45 ` Sagi Grimberg
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191105175812.GE18972@lst.de \ --to=hch@lst.de \ --cc=idanb@mellanox.com \ --cc=israelr@mellanox.com \ --cc=kbusch@kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=maxg@mellanox.com \ --cc=oren@mellanox.com \ --cc=sagi@grimberg.me \ --cc=shlomin@mellanox.com \ --cc=vladimirk@mellanox.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-NVME Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-nvme/0 linux-nvme/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-nvme linux-nvme/ https://lore.kernel.org/linux-nvme \ linux-nvme@lists.infradead.org public-inbox-index linux-nvme Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.infradead.lists.linux-nvme AGPL code for this site: git clone https://public-inbox.org/public-inbox.git