From: Keith Busch <kbusch@kernel.org>
To: Sasha Levin <sashal@kernel.org>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Marta Rybczynska <mrybczyn@kalray.eu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Charles Machalow <csm10495@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-nvme <linux-nvme@lists.infradead.org>, axboe <axboe@fb.com>,
stable@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd
Date: Wed, 6 Nov 2019 09:18:39 +0900 [thread overview]
Message-ID: <20191106001839.GB1450@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <20191106000836.GH4787@sasha-vm>
On Tue, Nov 05, 2019 at 07:08:36PM -0500, Sasha Levin wrote:
> On Tue, Nov 05, 2019 at 04:31:44PM +0100, Christoph Hellwig wrote:
> > On Tue, Nov 05, 2019 at 08:39:12AM +0100, Marta Rybczynska wrote:
> > > Looks good to me. However, please note that the new ioctl made it already to 5.3.8.
> >
> > It wasn't in 5.3, but it seems like you are right and it somehow got
> > picked for the stable releases.
> >
> > Sasha, can you please revert 76d609da9ed1cc0dc780e2b539d7b827ce28f182
> > in 5.3-stable ASAP and make sure crap like backporting new ABIs that
> > haven't seen a release yet is never ever going to happen again?
>
> Sure, I'll revert it. I guess I wasn't expecting to see something like
> this in a -rc release. How did it make it into one if it's not a fix?
It is a fix, but it wasn't marked as such in the original changelog.
I've adjusted it for the pull request, currently staged here:
https://git.kernel.dk/cgit/linux-block/commit/?h=for-linus&id=0d6eeb1fd625272bd60d25f2d5e116cf582fc7dc
Still, a new ioctl seems pretty aggressive for stable bot, yeah?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-11-06 0:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 6:15 [PATCH] nvme: change nvme_passthru_cmd64 to explicitly mark rsvd Charles Machalow
2019-11-05 7:39 ` Marta Rybczynska
2019-11-05 15:31 ` Christoph Hellwig
2019-11-06 0:08 ` Sasha Levin
2019-11-06 0:18 ` Keith Busch [this message]
2019-11-06 1:09 ` Christoph Hellwig
2019-11-05 14:34 ` Christoph Hellwig
2019-11-05 15:26 ` Keith Busch
2019-11-05 20:56 ` Charles Machalow
2019-11-05 21:21 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106001839.GB1450@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=axboe@fb.com \
--cc=csm10495@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mrybczyn@kalray.eu \
--cc=sagi@grimberg.me \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).