From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D1D9C5DF63 for ; Wed, 6 Nov 2019 20:43:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50986217F5 for ; Wed, 6 Nov 2019 20:43:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YqQMulWR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="tUML1ucu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50986217F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kdD69JeGduHwUA42Hp1v+34hw0SZGUFzPAiTuROT0ag=; b=YqQMulWRikPn/d Zm7wSeXh7tMqR6LaVgKYvpnBvWne7LGlFIuPlRVrojsuPuQf2vwGzrOzXBghYklX4FFKpS1dX8XKf 1BZRawaTKEuTnqND9aFGuc1t5BUK0a6pSt8DOwe2bDMXtxtZ2C/mBN4sEhcQIpfXx269tZJc+dxrO bXKU2vCM8pmDkFnVKiIXG0hI7fNQs57I5HTQ8KkudY9NPo+vrzU5fgw2sovnElF2QTMoAN8RzS+T7 453E4g6dF5PzqNivyEZYnR6goO5i5rT+YCD9us1iFMiWzTHWOgPhSHSyRpabKWUYJgzuWLpht1//t sFZXK/C0axX+JpzTFZ3A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSS9T-0004zT-Nh; Wed, 06 Nov 2019 20:43:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSS9Q-0004z9-Ro for linux-nvme@lists.infradead.org; Wed, 06 Nov 2019 20:43:38 +0000 Received: from redsun51.ssa.fujisawa.hgst.com (unknown [199.255.47.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 877672178F; Wed, 6 Nov 2019 20:43:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573073016; bh=8Mn693rQoM2SAydIBUESVHGciXllzel1bh7+lM2nxjA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tUML1ucuxsTTRG834Mu9c7IqLfyH/YnnbsVj+IzDqtUGa13k+UIi0oC++1UEbGBQi t/xjlt4rc6BqKyewalbZDpjTb6qkWGXsd7D1kr06DHskj2qrsaa2hqNyQ9sY907PCf SOqT0t0w+Svc/zf5iLzlUNuSGFaT3vfdv315hVxw= Date: Thu, 7 Nov 2019 05:43:29 +0900 From: Keith Busch To: Eduard Hasenleithner Subject: Re: [RFC PATCH] Workaround for discard on non-conformant nvme devices Message-ID: <20191106204329.GB32215@redsun51.ssa.fujisawa.hgst.com> References: <20191106182339.GE29853@redsun51.ssa.fujisawa.hgst.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191106_124336_917907_5BE8753B X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagi Grimberg , linux-nvme@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Nov 06, 2019 at 09:22:00PM +0100, Eduard Hasenleithner wrote: > On 06.11.19 19:23, Keith Busch wrote: > > > This needs to come with a quirk for it. > > > > Yeah, and have the broken ones to use the ctrl->discard_page so that you > > don't need to worry about the alignment of the address kmalloc returns. > > This raises some questions for me. > Why bother maintaining a quirk list and have additional complexity with > separate code paths? It documents the code on why the driver is doing spec non-compliant behavior. > Couldn't we just simply use the discard_page for all discards? That's normally just a fallback to ensure forward progress under memory pressure. It's not particularly performant, though. > Are there even nvme devices out there which have conformant behavior in this > respect? I believe most of them do conform, but I don't have a large sample size to confirm. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme