From: Pavel Machek <pavel@ucw.cz>
To: Keith Busch <kbusch@kernel.org>
Cc: Sagi Grimberg <sagi@grimberg.me>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org,
Akinobu Mita <akinobu.mita@gmail.com>, Jens Axboe <axboe@fb.com>,
Chris Healy <cphealy@gmail.com>, Christoph Hellwig <hch@lst.de>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v2] nvme: Add hardware monitoring support
Date: Wed, 6 Nov 2019 22:29:21 +0100 [thread overview]
Message-ID: <20191106212921.GA7020@amd> (raw)
In-Reply-To: <20191030005327.GC15332@redsun51.ssa.fujisawa.hgst.com>
[-- Attachment #1.1: Type: text/plain, Size: 1654 bytes --]
Hi!
> > nvme devices report temperature information in the controller information
> > (for limits) and in the smart log. Currently, the only means to retrieve
> > this information is the nvme command line interface, which requires
> > super-user privileges.
> >
> > At the same time, it would be desirable to use NVME temperature information
> > for thermal control.
> >
> > This patch adds support to read NVME temperatures from the kernel using the
> > hwmon API and adds temperature zones for NVME drives. The thermal subsystem
> > can use this information to set thermal policies, and userspace can access
> > it using libsensors and/or the "sensors" command.
> >
> > Example output from the "sensors" command:
> >
> > nvme0-pci-0100
> > Adapter: PCI adapter
> > Composite: +39.0°C (high = +85.0°C, crit = +85.0°C)
> > Sensor 1: +39.0°C
> > Sensor 2: +41.0°C
> >
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> This looks fine to me, but I'll wait a few more days to see if there are
> any additional comments..
User wants to know temperature of /dev/sda... and we already have an
userspace tools knowing about smart, etc...
pavel@amd:/data/film$ sudo hddtemp /dev/sda
/dev/sda: ST1000LM014-1EJ164: 48°C
I see we also have sensors framework but it does _not_ handle
harddrive temperatures.
Does it need some kind of unification? Should NVMe devices expose
"SMART" information in the same way other SSDs do?
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 158 bytes --]
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-11-06 21:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 22:32 [PATCH v2] nvme: Add hardware monitoring support Guenter Roeck
2019-10-30 0:53 ` Keith Busch
2019-11-06 21:29 ` Pavel Machek [this message]
2019-11-06 22:30 ` Guenter Roeck
2019-11-06 23:58 ` Chris Healy
2019-10-30 11:16 ` Akinobu Mita
2019-10-30 14:05 ` Christoph Hellwig
2019-10-31 2:54 ` Guenter Roeck
2019-10-31 13:46 ` Christoph Hellwig
2019-10-31 13:46 ` Akinobu Mita
2019-10-31 2:20 ` Guenter Roeck
2019-10-31 13:44 ` Akinobu Mita
2019-10-31 13:45 ` Christoph Hellwig
2019-10-31 17:54 ` Guenter Roeck
2019-10-30 14:12 ` Christoph Hellwig
2019-10-30 23:40 ` Chris Healy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106212921.GA7020@amd \
--to=pavel@ucw.cz \
--cc=akinobu.mita@gmail.com \
--cc=axboe@fb.com \
--cc=cphealy@gmail.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).