From: Keith Busch <kbusch@kernel.org>
To: Eduard Hasenleithner <eduard@hasenleithner.at>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH v3] Workaround for discard on non-conformant nvme devices
Date: Tue, 12 Nov 2019 07:37:07 +0900 [thread overview]
Message-ID: <20191111223707.GA7595@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <aa716b06-6e9a-f668-49b4-4007bd3bffae@hasenleithner.at>
On Mon, Nov 11, 2019 at 11:07:43PM +0100, Eduard Hasenleithner wrote:
> { PCI_VDEVICE(INTEL, 0xf1a5), /* Intel 600P/P3100 */
> .driver_data = NVME_QUIRK_NO_DEEPEST_PS |
> - NVME_QUIRK_MEDIUM_PRIO_SQ },
> + NVME_QUIRK_MEDIUM_PRIO_SQ |
> + NVME_QUIRK_DSM_PAGEALIGN, },
> { PCI_VDEVICE(INTEL, 0xf1a6), /* Intel 760p/Pro 7600p */
> - .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN, },
> + .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
> + NVME_QUIRK_DSM_PAGEALIGN, },
> + { PCI_VDEVICE(INTEL, 0xf1a8), /* Intel 660p */
> + .driver_data = NVME_QUIRK_DSM_PAGEALIGN, },
> { PCI_VDEVICE(INTEL, 0x5845), /* Qemu emulated controller */
> .driver_data = NVME_QUIRK_IDENTIFY_CNS |
> NVME_QUIRK_DISABLE_WRITE_ZEROES, },
> + { PCI_DEVICE(0x126f, 0x2260), /* Silicon Motion SM2260 */
> + .driver_data = NVME_QUIRK_DSM_PAGEALIGN, },
> + { PCI_DEVICE(0x126f, 0x2262), /* Silicon Motion SM2262 */
> + .driver_data = NVME_QUIRK_DSM_PAGEALIGN, },
> + { PCI_DEVICE(0x126f, 0x2263), /* Silicon Motion SM2263 */
> + .driver_data = NVME_QUIRK_DSM_PAGEALIGN, },
> + { PCI_DEVICE(0x126f, 0x2265), /* Silicon Motion SM2265 */
> + .driver_data = NVME_QUIRK_DSM_PAGEALIGN, },
>
> + { PCI_DEVICE(0x1987, 0x5012), /* Phison E12 */
> + .driver_data = NVME_QUIRK_DSM_PAGEALIGN, },
> + { PCI_DEVICE(0x1987, 0x5016), /* Phison E16 */
> + .driver_data = NVME_QUIRK_DSM_PAGEALIGN, },
> { PCI_DEVICE(0x1bb1, 0x0100), /* Seagate Nytro Flash Storage */
> .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
> { PCI_DEVICE(0x1c58, 0x0003), /* HGST adapter */
> @@ -3038,6 +3054,8 @@ static const struct pci_device_id nvme_i
> .driver_data = NVME_QUIRK_LIGHTNVM, },
> { PCI_DEVICE(0x10ec, 0x5762), /* ADATA SX6000LNP */
> .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN, },
> + { PCI_DEVICE(0xc0a9, 0x2263), /* Crucial P1 (SM2263) */
> + .driver_data = NVME_QUIRK_DSM_PAGEALIGN, },
Aha, I'm seeing a pattern here: SMI makes the controllers for at least
8 of the 10 needing this behavior.
Patch looks fine to me. I'll give this a short time to see if there's
additional comments before committing for the next merge window.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-11-11 22:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 22:07 [PATCH v3] Workaround for discard on non-conformant nvme devices Eduard Hasenleithner
2019-11-11 22:37 ` Keith Busch [this message]
2019-11-12 1:31 ` Sagi Grimberg
2019-11-12 16:37 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111223707.GA7595@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=eduard@hasenleithner.at \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).