From: Ming Lei <ming.lei@redhat.com>
To: linux-nvme@lists.infradead.org
Cc: Sagi Grimberg <sagi@grimberg.me>, Long Li <longli@microsoft.com>,
Jens Axboe <axboe@fb.com>,
Nadolski Edmund <edmund.nadolski@intel.com>,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V3 0/2] nvme-pci: check CQ after batch submission for Microsoft device
Date: Thu, 21 Nov 2019 11:11:54 +0800 [thread overview]
Message-ID: <20191121031154.GJ24548@ming.t460p> (raw)
In-Reply-To: <20191114025917.24634-1-ming.lei@redhat.com>
On Thu, Nov 14, 2019 at 10:59:15AM +0800, Ming Lei wrote:
> Hi,
>
> The two patches fix one performance regression on Microsoft Corporation device. The
> root cause is that Microsoft device applies aggressive interrupt coalescing, so
> single job fio performance drops much after we removes checking cq in
> f9dde187fa92("nvme-pci: remove cq check after submission").
>
> Turns out this issue is very specific on Microsoft device, so add
> a quirk for checking CQ on this device.
>
> V3:
> - replace spin_trylock_irqsave with spin_trylock_irq
> - fix comment on cq_lock & cq_poll_lock
>
> V2:
> - only check CQ for Microsoft device.
>
>
>
> Ming Lei (2):
> nvme-pci: move sq/cq_poll lock initialization into nvme_init_queue
> nvme-pci: check CQ after batch submission for Microsoft device
>
> drivers/nvme/host/nvme.h | 6 +++
> drivers/nvme/host/pci.c | 98 ++++++++++++++++++++++++++++++++++------
> 2 files changed, 90 insertions(+), 14 deletions(-)
>
> Cc: Keith Busch <kbusch@kernel.org>
> Cc: Jens Axboe <axboe@fb.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Sagi Grimberg <sagi@grimberg.me>
> Cc: Long Li <longli@microsoft.com>
> --
> 2.20.1
>
Hi Guys,
Ping...
Thanks,
Ming
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-11-21 3:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 2:59 [PATCH V3 0/2] nvme-pci: check CQ after batch submission for Microsoft device Ming Lei
2019-11-14 2:59 ` [PATCH V3 1/2] nvme-pci: move sq/cq_poll lock initialization into nvme_init_queue Ming Lei
2019-11-14 2:59 ` [PATCH V3 2/2] nvme-pci: check CQ after batch submission for Microsoft device Ming Lei
2019-11-14 4:56 ` Keith Busch
2019-11-14 8:56 ` Ming Lei
2019-11-21 3:11 ` Ming Lei [this message]
2019-11-21 6:14 ` [PATCH V3 0/2] " Christoph Hellwig
2019-11-21 7:46 ` Ming Lei
2019-11-21 15:45 ` Keith Busch
2019-11-22 9:44 ` Ming Lei
2019-11-22 9:57 ` Christoph Hellwig
2019-11-22 10:25 ` Ming Lei
2019-11-22 14:04 ` Jens Axboe
2019-11-22 21:49 ` Ming Lei
2019-11-22 21:58 ` Jens Axboe
2019-11-22 22:30 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121031154.GJ24548@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@fb.com \
--cc=edmund.nadolski@intel.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=longli@microsoft.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).