From: Ming Lei <ming.lei@redhat.com>
To: Keith Busch <kbusch@kernel.org>
Cc: Sagi Grimberg <sagi@grimberg.me>, Long Li <longli@microsoft.com>,
linux-nvme@lists.infradead.org, Jens Axboe <axboe@fb.com>,
Nadolski Edmund <edmund.nadolski@intel.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V3 0/2] nvme-pci: check CQ after batch submission for Microsoft device
Date: Fri, 22 Nov 2019 17:44:57 +0800 [thread overview]
Message-ID: <20191122094457.GA23632@ming.t460p> (raw)
In-Reply-To: <20191121154531.GB17852@redsun51.ssa.fujisawa.hgst.com>
On Fri, Nov 22, 2019 at 12:45:31AM +0900, Keith Busch wrote:
> On Thu, Nov 21, 2019 at 03:46:43PM +0800, Ming Lei wrote:
> > On Thu, Nov 21, 2019 at 07:14:31AM +0100, Christoph Hellwig wrote:
> > > On Thu, Nov 21, 2019 at 11:11:54AM +0800, Ming Lei wrote:
> > > > Hi Guys,
> > > >
> > > > Ping...
> > >
> > > I think everyone has told you that it is an invasive horrible hack
> > > that papers of the underlying problem(s). I'm not sure what more
> > > we can do here.
> >
> > The problem is that the NVMe driver applies aggressive interrupt
> > coalescing clearly, that can be addressed exactly by this approach.
>
> Can this default coalescing setting be turned off with a "set feature"
> command?
>
At default, 'get feature -f 0x8' shows zero, and nothing changes after
running 'set feature -f 0x8 -v 0'.
BTW, soft lockup from another Samsung NVMe can be fixed by this patch
too. I am confirming if the Samsung NVMe applies aggressive interrupt
coalescing too.
Thanks,
Ming
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-11-22 9:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 2:59 [PATCH V3 0/2] nvme-pci: check CQ after batch submission for Microsoft device Ming Lei
2019-11-14 2:59 ` [PATCH V3 1/2] nvme-pci: move sq/cq_poll lock initialization into nvme_init_queue Ming Lei
2019-11-14 2:59 ` [PATCH V3 2/2] nvme-pci: check CQ after batch submission for Microsoft device Ming Lei
2019-11-14 4:56 ` Keith Busch
2019-11-14 8:56 ` Ming Lei
2019-11-21 3:11 ` [PATCH V3 0/2] " Ming Lei
2019-11-21 6:14 ` Christoph Hellwig
2019-11-21 7:46 ` Ming Lei
2019-11-21 15:45 ` Keith Busch
2019-11-22 9:44 ` Ming Lei [this message]
2019-11-22 9:57 ` Christoph Hellwig
2019-11-22 10:25 ` Ming Lei
2019-11-22 14:04 ` Jens Axboe
2019-11-22 21:49 ` Ming Lei
2019-11-22 21:58 ` Jens Axboe
2019-11-22 22:30 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122094457.GA23632@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@fb.com \
--cc=edmund.nadolski@intel.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=longli@microsoft.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).