From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD85EC432C0 for ; Fri, 29 Nov 2019 08:25:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83E8C21781 for ; Fri, 29 Nov 2019 08:25:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qv1ghfTm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83E8C21781 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jmiQSnnE8liEILwwtH0TT8MLBpx35Dwsq90fEUMANEY=; b=qv1ghfTmnxQq9k MjSOqqO/uTVLjo/LPL79BXodRaz2VH3mUJaSMTk+QZH+vcn8sLDob7E3KY42Ib8MTDbC5qxLdSHwf 6yDAtxzBMkPlpM6ZqRQPh1Gf3RxoZX9wYguANy4gIqi8LwBjnb6sZOmue3I42k4GWmSTxjP6ShME4 u8uvkLw3B+bV1j8GG/MrENzHu4BiVAR5LWOm4/xaZlYZpA4lqUw0xxKHF5rFQwgKhUVCVPKEvreJH cLEhsNlQvC4RKwSUD7rBqOuEkM0Wd4jQjXRDnkC9Bhr//7m5n3Nkv36pmaGAEM4pfMsl9VPr0QIZc QhgnHNAjYGuAwTqhEIxw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iabaF-00027i-BI; Fri, 29 Nov 2019 08:24:59 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iabaD-00027E-BQ for linux-nvme@lists.infradead.org; Fri, 29 Nov 2019 08:24:58 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id E65FC68AFE; Fri, 29 Nov 2019 09:24:49 +0100 (CET) Date: Fri, 29 Nov 2019 09:24:49 +0100 From: Christoph Hellwig To: Balbir Singh Subject: Re: [RFC][PATCH] nvme/core: Notify udev about capacity change Message-ID: <20191129082449.GA9953@lst.de> References: <20191129002746.6622-1-sblbir@amazon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191129002746.6622-1-sblbir@amazon.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191129_002457_537984_A1E5A612 X-CRM114-Status: UNSURE ( 6.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagi Grimberg , linux-nvme@lists.infradead.org, Jens Axboe , Someswarudu Sangaraju , Keith Busch , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org I don't think this makes sense, and they way it has been done in virtio_blk and xen-blkfront is an utter hack. Please first add a properly documented block helper, and then make sure it doesn't send the even for the first call that moves from a 0 capacity. SCSI also will need updating to use the helper. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme