From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBB7FC432C0 for ; Fri, 29 Nov 2019 09:46:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ACEA7215F1 for ; Fri, 29 Nov 2019 09:46:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bBB15p8b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACEA7215F1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x9OPyDnSegSf0KvMBNwusjnkswNfqWtO6RdL57sFwts=; b=bBB15p8bQe08xJ jxyXMc0ttTepZVCbWZQWZWUiE9ulc7ZM2krU2IuA+ciFsntpms07TwxlEN16qmTt/UDR9nhgDVISj CSXGG4QjjlVL2C4Xe57zd+PEKb8LVebpElw114HrOBG9Cjk80ndDOATiDNRYKKR2nTp3KEcn/UcIv ExGj7t2DsHwzYL5yTWvCNyRwbwcS69QC512atzc9dss+3b15N6ELH6yok5mOQ4bYY3LVR2IDGeIsr y3Lwbej9UM8VgesNpa4uDbatIK61GwlWEb+3ZR/Cf2Ab9oVQ58YmYwdjAALSFtPQ+VVQ5tBJz9Mo7 cG7l9A7NHNgjf5VDFPgw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iacrM-0000gh-U0; Fri, 29 Nov 2019 09:46:44 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iacrK-0000gB-Lz for linux-nvme@lists.infradead.org; Fri, 29 Nov 2019 09:46:43 +0000 Received: from bigeasy by Galois.linutronix.de with local (Exim 4.80) (envelope-from ) id 1iacrI-0002HH-Ta; Fri, 29 Nov 2019 10:46:40 +0100 Date: Fri, 29 Nov 2019 10:46:40 +0100 From: Sebastian Andrzej Siewior To: Keith Busch Subject: Re: [PATCH 0/4] nvme: Threaded interrupt handling improvements Message-ID: <20191129094640.6fq6wcxmfi4fwnlw@linutronix.de> References: <20191127175824.1929-1-kbusch@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191127175824.1929-1-kbusch@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191129_014642_863061_78D51E9B X-CRM114-Status: UNSURE ( 6.79 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ming.lei@redhat.com, helgaas@kernel.org, hch@lst.de, linux-nvme@lists.infradead.org, sagi@grimberg.me Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 2019-11-28 02:58:20 [+0900], Keith Busch wrote: > Threaded interrupts allow the device to continue sending interrupt > messages while the driver is handling the previous notification. This > can cause a significant amount of CPU cycles unnecessarily spent in hard > irq context, and potentially triggers spurious interrupt detection to > disable the nvme interrupt. Thank you for looking into this. To be clear: the "spurious interrupt detector" won't do a thing if you never return IRQ_NONE. As long as you return IRQ_HANDLED, everything is fine. Sebastian _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme