From: Keith Busch <kbusch@kernel.org>
To: linux-nvme@lists.infradead.org
Cc: sagi@grimberg.me, bigeasy@linutronix.de, ming.lei@redhat.com,
helgaas@kernel.org, Keith Busch <kbusch@kernel.org>,
tglx@linutronix.de, hch@lst.de
Subject: [PATCHv2 0/2]
Date: Tue, 3 Dec 2019 07:20:56 +0900 [thread overview]
Message-ID: <20191202222058.2096-1-kbusch@kernel.org> (raw)
NVMe devices had been able to continue sending interrupt messages while
the driver is handling the previous notification when threaded interrupts
are used. This can cause unnecessary CPU cycles spent in hard irq context,
and potentially triggers spurious interrupt detection if the threaded
handler runs sufficiently long: returning IRQ_WAKE_THREAD from the
primrary handler doesn't observe any changes to irq desc->thread_handled.
Use the appropriate masking for the interrupt type based on the NVMe
specification recommendations (see NVMe 1.4 section 7.5.1.1 for more
information) so that the primary handler does not get unnecessarily
triggered.
v1 -> v2:
Don't split the nvme callbacks for MSI and MSI-x. Just check the type
in the callback when selecting the masking method, and combine this
in a single patch.
Drop the more experiemental patches. That series will be posted
separately.
Keith Busch (2):
PCI/MSI: Export __pci_msix_desc_mask_irq
nvme/pci: Mask device interrupts for threaded handlers
drivers/nvme/host/pci.c | 28 ++++++++++++++++++++++++----
drivers/pci/msi.c | 1 +
2 files changed, 25 insertions(+), 4 deletions(-)
--
2.21.0
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next reply other threads:[~2019-12-02 22:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 22:20 Keith Busch [this message]
2019-12-02 22:20 ` [PATCHv2 1/2] PCI/MSI: Export __pci_msix_desc_mask_irq Keith Busch
2019-12-02 22:46 ` Christoph Hellwig
2019-12-03 9:04 ` Sebastian Andrzej Siewior
2019-12-06 21:18 ` Keith Busch
2019-12-02 22:20 ` [PATCHv2 2/2] nvme/pci: Mask device interrupts for threaded handlers Keith Busch
2019-12-03 7:47 ` Christoph Hellwig
2019-12-03 12:07 ` Keith Busch
2019-12-04 10:10 ` Sironi, Filippo
2019-12-04 13:58 ` hch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191202222058.2096-1-kbusch@kernel.org \
--to=kbusch@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=hch@lst.de \
--cc=helgaas@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).