From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 976CBC432C0 for ; Tue, 3 Dec 2019 09:39:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B29420661 for ; Tue, 3 Dec 2019 09:39:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="A6WTRW7P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B29420661 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xSRbzZhIBYUk4NMisv82oYeH7MCNUnBesbRz/fr7LIY=; b=A6WTRW7Pg6RL9I RbWVFiYo7tl3j6P3zXx6hG5M2KoqOnKV1+jfyEoSk6XvDd1eFOIz3CVkyMf0S5JQMujmJdr9QHEsw 40zW1M2hWHMWtMl3xP63sPQk2wliT1FY5msEkFLJvgLcVcDlIIIGScya4oHa9fpU4B2pvRnJq+i6d ngynLNRZcStQWqaRH8x/oyW71p+eQ6Ux9XxozfuifazgZQKBrP1ai9AHvdgup++V98ti2ZhqfqF1C tEnLrBX2JbySESp+ZaBbLlxKWrGvzzMRvCcqwCegemuKVt7PMDqhPKj/2fEe+XMCbi2TdTSWdIeko 9OzGVSeCkxVa7ZulGn4g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic4eB-0001xQ-74; Tue, 03 Dec 2019 09:39:07 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic4e8-0001wu-EJ for linux-nvme@lists.infradead.org; Tue, 03 Dec 2019 09:39:05 +0000 Received: from bigeasy by Galois.linutronix.de with local (Exim 4.80) (envelope-from ) id 1ic4e4-0007Wm-A6; Tue, 03 Dec 2019 10:39:00 +0100 Date: Tue, 3 Dec 2019 10:39:00 +0100 From: Sebastian Andrzej Siewior To: Christoph Hellwig Subject: Re: [RFC PATCH 1/3] nvme/pci: Poll the cq in the primary irq handler Message-ID: <20191203093900.r4lue7juxw76x6fa@linutronix.de> References: <20191202222206.2225-1-kbusch@kernel.org> <20191202222206.2225-2-kbusch@kernel.org> <20191203075046.GF23881@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191203075046.GF23881@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191203_013904_622991_A67A8147 X-CRM114-Status: UNSURE ( 8.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Busch , tglx@linutronix.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, ming.lei@redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On 2019-12-03 08:50:46 [+0100], Christoph Hellwig wrote: > On Tue, Dec 03, 2019 at 07:22:04AM +0900, Keith Busch wrote: > > The nvme threaded interrupt handler reduces CPU time spent in hard irq > > context, but waking it increases latency for low queue depth workloads. > > > > Poll the completion queue once from the primary handler and wake the > > thread only if more completions remain after. > > How is this going to work with -rt, which wants to run all actual > interrupt work in the irq thread? It will thread both handlers. Sebastian _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme