Linux-NVME Archive on
 help / color / Atom feed
From: Keith Busch <>
To: Christoph Hellwig <>
Subject: Re: [PATCH] nvme/pci: Remove last_cq_head
Date: Wed, 4 Dec 2019 00:41:16 +0900
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Dec 03, 2019 at 08:36:55AM +0100, Christoph Hellwig wrote:
> On Tue, Dec 03, 2019 at 07:18:29AM +0900, Keith Busch wrote:
> > We had been saving the last_cq_head seen from an interrupt so that a
> > polled queue wouldn't mistakenly trigger spruious interrupt detection. We
> > don't poll interrupt driven queues any more, so saving this value is
> > pointless.
> Looks good:
> Reviewed-by: Christoph Hellwig <>

Thanks, applied for-5.5.
> Btw, didn't you also have some other patches to shrink the size of
> struct nvme_queue from a few months ago?

Yes, I need to rebase those and do more testing. As long as no kernel
debugging is enabled, I believe we can fit all the nvmeq hot data in
one 64B cache line.

This was just the first patch. I doubt I'll be able to get the rest
completed for the current merge window, though.

linux-nvme mailing list

      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02 22:18 Keith Busch
2019-12-03  7:36 ` Christoph Hellwig
2019-12-03 15:41   ` Keith Busch [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-NVME Archive on

Archives are clonable:
	git clone --mirror linux-nvme/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-nvme linux-nvme/ \
	public-inbox-index linux-nvme

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone