From: Christoph Hellwig <hch@infradead.org>
To: Amit <Amit.Engel@dell.com>
Cc: sagi@grimberg.me, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvmet: Fix req->data_len size in case of nvme_admin_get_features cmd, fid 0x81
Date: Thu, 5 Dec 2019 00:33:25 -0800 [thread overview]
Message-ID: <20191205083325.GA855@infradead.org> (raw)
In-Reply-To: <20191205081541.55962-1-amit.engel@emc.com>
->data_len is gone in latest mainline, instead
nvmet_execute_get_features check the transfer_len. But your
general scheme should apply there. I think a little
nvmet_feature_data_len helper to calculate the required length
would be nice, similar to what we do for read/write commands or
log pages.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-12-05 8:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 8:15 [PATCH] nvmet: Fix req->data_len size in case of nvme_admin_get_features cmd, fid 0x81 Amit
2019-12-05 8:33 ` Christoph Hellwig [this message]
2019-12-05 13:35 ` Engel, Amit
2019-12-09 13:21 ` Engel, Amit
2019-12-10 7:23 ` Chaitanya Kulkarni
2019-12-05 13:10 Amit
2019-12-05 13:14 Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205083325.GA855@infradead.org \
--to=hch@infradead.org \
--cc=Amit.Engel@dell.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).