From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: Mark Ruijter <MRuijter@onestopsystems.com>,
hch@lst.de, linux-nvme@lists.infradead.org
Subject: Re: [PATCH V4 2/3] nvmet: make ctrl model configurable
Date: Thu, 12 Dec 2019 10:28:42 +0100 [thread overview]
Message-ID: <20191212092842.GI2399@lst.de> (raw)
In-Reply-To: <20191127094034.12334-3-chaitanya.kulkarni@wdc.com>
> +static ssize_t nvmet_subsys_attr_model_show(struct config_item *item,
> + char *page)
> +{
> + struct nvmet_subsys *subsys = to_subsys(item);
> +
> + return snprintf(page, PAGE_SIZE, "%s\n",
> + nvmet_model_number(subsys));
This whole statements easily fits onto a single line.
> + down_write(&nvmet_config_sem);
> + kfree(subsys->model);
> + subsys->model = tmp_model;
> + up_write(&nvmet_config_sem);
Without using something like RCU this means all users of ->model
now need to take nvmet_config_sem. I guess using RCU here is simple
enough - just use rcu_swap_protected and kfree_rcu here.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-12-12 9:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 9:40 [PATCH 0/3] nvmet: make model/ctrl-id configurable, configfs fix Chaitanya Kulkarni
2019-11-27 9:40 ` [PATCH V3 1/3] nvmet: make ctrl-id configurable Chaitanya Kulkarni
2019-12-12 0:45 ` Sagi Grimberg
2019-12-12 9:22 ` Christoph Hellwig
2019-12-12 9:26 ` Christoph Hellwig
2019-12-16 20:40 ` Chaitanya Kulkarni
2019-11-27 9:40 ` [PATCH V4 2/3] nvmet: make ctrl model configurable Chaitanya Kulkarni
2019-12-12 0:45 ` Sagi Grimberg
2019-12-12 9:28 ` Christoph Hellwig [this message]
2019-12-12 9:46 ` Christoph Hellwig
2019-12-17 4:53 ` Chaitanya Kulkarni
2019-11-27 9:40 ` [PATCH V2 3/3] nvmet: check sscanf value for subsys serial attr Chaitanya Kulkarni
2019-12-12 0:46 ` Sagi Grimberg
2019-12-12 9:29 ` Christoph Hellwig
2019-12-11 5:35 ` [PATCH 0/3] nvmet: make model/ctrl-id configurable, configfs fix Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212092842.GI2399@lst.de \
--to=hch@lst.de \
--cc=MRuijter@onestopsystems.com \
--cc=chaitanya.kulkarni@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--subject='Re: [PATCH V4 2/3] nvmet: make ctrl model configurable' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).