From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DD89C43603 for ; Thu, 12 Dec 2019 09:46:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 016F8214D8 for ; Thu, 12 Dec 2019 09:46:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AsMm04jN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 016F8214D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hSqptJ+x9p7lqgNaQCkel1R4i84R9+eLzH9AnPdphjw=; b=AsMm04jN2RJBjE 8h7kL3tJ09W0OvryuJQmfzQESN5jMPJn3O0f7+iTG46LF4MDNY33wcfMCR6NSlYrXznEBmIV0RbYU 6QmKRn7Q4BE1A12v6UbdVft8Qb2I5d0CdZfae0bFxRpwfai7WAs1UqCGh+RD5JgMRHqA9HAEnmXt0 hM6ahd6nD0oMX0IuL7FiZKYHgm2iyyq+7X2o+KGSvHLzHhSktcpPzMFJkk3E7afwtbfjm283+INem XcIqdXFnN8IlGsMOindzAkjEr9AU2AyjAB9lPV8fpcEsGK5MRjSyDqkuB7nvAkUNBbF7W9fNQ0SLS esqXHg2MtZULDSYP/u5g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifL3R-0004F8-1r; Thu, 12 Dec 2019 09:46:41 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifL3O-0004Eg-4P for linux-nvme@lists.infradead.org; Thu, 12 Dec 2019 09:46:39 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 3BE2668B05; Thu, 12 Dec 2019 10:46:36 +0100 (CET) Date: Thu, 12 Dec 2019 10:46:36 +0100 From: Christoph Hellwig To: Chaitanya Kulkarni Subject: Re: [PATCH V4 2/3] nvmet: make ctrl model configurable Message-ID: <20191212094636.GA3681@lst.de> References: <20191127094034.12334-1-chaitanya.kulkarni@wdc.com> <20191127094034.12334-3-chaitanya.kulkarni@wdc.com> <20191212092842.GI2399@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191212092842.GI2399@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191212_014638_320571_8D906282 X-CRM114-Status: UNSURE ( 6.07 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Ruijter , hch@lst.de, linux-nvme@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Dec 12, 2019 at 10:28:42AM +0100, Christoph Hellwig wrote: > Without using something like RCU this means all users of ->model > now need to take nvmet_config_sem. I guess using RCU here is simple > enough - just use rcu_swap_protected and kfree_rcu here. Actually, this should be rcu_replace_pointer instead of rcu_swap_protected, which has been removed in for-next. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme