From: Logan Gunthorpe <email@example.com>
To: firstname.lastname@example.org, email@example.com
Cc: Sagi Grimberg <firstname.lastname@example.org>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Stephen Bates <email@example.com>, Jens Axboe <firstname.lastname@example.org>,
Keith Busch <email@example.com>, Max Gurtovoy <firstname.lastname@example.org>,
Logan Gunthorpe <email@example.com>,
Christoph Hellwig <firstname.lastname@example.org>
Subject: [PATCH v10 0/9] nvmet: add target passthru commands support
Date: Thu, 12 Dec 2019 16:54:09 -0700 [thread overview]
Message-ID: <email@example.com> (raw)
This is v9 of the passthru patchset. This addresses the vast majority
of Christoph's feedback from v9 and rebases onto v5.5-rc1. There were
a couple issues that were not addressed discussed below.
I don't think cloning the ctrl_id or the subsysnqn is a good idea.
I sent an email trying to explain why here but there was no response.
In short, I think cloning the ctrl_id will break multipathing over
fabrics and copying the subsysnqn only has the effect of breaking
loopback; the user can always copy the underlying subsysnqn if it
makes sense for their overall system.
I maintain overriding the CMIC bit in the ctrl id is necessary to
allow multipath over fabrics even if the underlying device did
not support multipath.
I also think the black list for admin commands is appropriate, and I
added it based on Sagi's feedback. There are plenty of commands that
may be dangerous like firmware update and format NVM commands, and NS
attach commands won't work out of the box because we don't copy the
ctrl_id. It seems like there's more commands to be careful of than ones
that are that are obviously acceptable. So, I think the prudent course
is blacklisting by default until someone has a usecase and can show
the command is safe seems and makes sense. For our present use cases,
the identify, log page and vendor specific commands are all that we
1. Rebased onto v5.5-rc1
2. Disable all exports in core nvme if CONFIG_NVME_TARGET_PASSTHRU is
not set and put them near the end of the file with a big fat
comment (per Christoph)
3. Don't fake up the vs field: pass it through as is and bump
it to 1.2.1 if it is below that (per Christoph)
4. Rework how passthru requests are submitted into the core
with proper nvme_passthru_start/end handling (per Christoph)
5. Rework how commands are parsed with passthru hooks in
parse_admin_cmd() and nvmet_parse_io_cmd() (per Christoph)
6. Rework commands are handled so they are only done in a work
item if absolutely necessary (per Christoph)
7. The data_len hack was dropped as a patchset was introduced to
remove data_len altogether (per Christoph)
8. The passthru accounting changes are now in v5.5-rc1
9. A large number of other minor cleanups that were pointed out by
1. Rebased onto v5.4-rc2 (required adjusting nvme_identify_ns() usage)
2. Collected Sagi's Reviewed-By Tags
3. Squashed seperate Kconfig patch into passthru patch (Per Sagi)
4. Set REQ_FUA for flush requests and remove special casing
on RQF_IO_STAT (Per Sagi)
1. Rebased onto v5.3-rc6
2. Collected Max's Reviewed-By tags
3. Converted admin command black-list to a white-list, but
allow all vendor specific commands. With this, we feel
it's safe to allow multiple connections from hosts.
(As per Sagi's feedback)
1. Rebased onto v5.3-rc2
2. Rework nvme_ctrl_get_by_path() to use filp_open() instead of
the cdev changes that were in v6. (Per Al)
3. Override the cmic bit to allow multipath and allow
multiple connections from the same hostnqn. (At the same
time I cleaned up the method of rejecting multiple connections.)
See Patch 8)
4. Found a bug when used with the tcp transport (See Patch 10)
1. Rebased onto v5.3-rc1
2. Rework configfs interface to simply be a passthru directory
within the existing subsystem. The directory is similar to
and consistent with a namespace directory.
3. Have the configfs take a path instead of a bare controller name
4. Renamed the main passthru file to io-cmd-passthru.c for consistency
with the file and block-dev methods.
5. Cleaned up all the CONFIG_NVME_TARGET_PASSTHRU usage to remove
all the inline #ifdefs
6. Restructured nvmet_passthru_make_request() a bit for clearer code
7. Moved nvme_find_get_ns() call into nvmet_passthru_execute_cmd()
seeing calling it in nvmet_req_init() causes a lockdep warning
due to nvme_find_get_ns() being able to sleep.
8. Added a check in nvmet_passthru_execute_cmd() to ensure we don't
violate queue_max_segments or queue_max_hw_sectors and overrode
mdts to ensure hosts don't intentionally submit commands
that will exceed these limits.
9. Reworked the code which ensures there's only one subsystem per
passthru controller to use an xarray instead of a list as this is
simpler and more easily fixed some bugs triggered by disabling
subsystems that weren't enabled.
10. Removed the overide of the target cntlid with the passthru cntlid;
this seemed like a really bad idea especially in the presence of
mixed systems as you could end up with two ctrlrs with the same
cntlid. For now, commands that depend on cntlid are black listed.
11. Implement block accounting for passthru so the target can track
usage using /proc/diskstats
12. A number of other minor bug fixes and cleanups
v5 Changes (not sent to list, from Chaitanya):
1. Added workqueue for admin commands.
2. Added kconfig option for the pass-thru feature.
3. Restructure the parsing code according to your suggestion,
call nvmet_xxx_parse_cmd() from nvmet_passthru_parse_cmd().
4. Use pass-thru instead of pt.
5. Several cleanups and add comments at the appropriate locations.
6. Minimize the code for checking pass-thru ns across all the subsystems.
7. Removed the delays in the ns related admin commands since I was
not able to reproduce the previous bug.
1. Add request polling interface to the block layer.
2. Use request polling interface in the NVMEoF target passthru code
3. Add checks suggested by Sagi for creating one target ctrl per
4. Don't enable the namespace if it belongs to the configured passthru
5. Adjust the code latest kernel.
1. Split the addition of passthru command handlers and integration
into two different patches since we add guards to create one target
controller per passthru controller. This way it will be easier to
review the code.
2. Adjust the code for 4.18.
1. Update the new nvme core controller find API naming and
changed the string comparison of the ctrl.
2. Get rid of the newly added #defines for target ctrl values.
3. Use the newly added structure members in the same patch where
they are used. Aggregate the passthru command handling support
and integration with nvmet-core into one patch.
4. Introduce global NVMe Target subsystem list for connected and
not connected subsystems on the target side.
5. Add check when configuring the target ns and target
passthru ctrl to allow only one target controller to be created
for one passthru subsystem.
6. Use the passthru ctrl cntlid when creating the
Chaitanya Kulkarni (1):
nvmet-passthru: Introduce NVMet passthru Kconfig option
Logan Gunthorpe (8):
nvme-core: Clear any SGL flags in passthru commands
nvme: Create helper function to obtain command effects
nvme: Move nvme_passthru_[start|end]() calls to common helper
nvme-core: Introduce nvme_ctrl_get_by_path()
nvme: Export existing nvme core functions
nvmet-passthru: Add passthru code to process commands
nvmet-passthru: Add enable/disable helpers
nvmet-configfs: Introduce passthru configfs interface
drivers/nvme/host/core.c | 229 ++++++++++-------
drivers/nvme/host/nvme.h | 14 +
drivers/nvme/target/Kconfig | 10 +
drivers/nvme/target/Makefile | 1 +
drivers/nvme/target/admin-cmd.c | 7 +-
drivers/nvme/target/configfs.c | 102 ++++++++
drivers/nvme/target/core.c | 13 +-
drivers/nvme/target/nvmet.h | 52 ++++
drivers/nvme/target/passthru.c | 435 ++++++++++++++++++++++++++++++++
include/linux/nvme.h | 1 +
10 files changed, 771 insertions(+), 93 deletions(-)
create mode 100644 drivers/nvme/target/passthru.c
linux-nvme mailing list
next reply other threads:[~2019-12-12 23:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 23:54 Logan Gunthorpe [this message]
2019-12-12 23:54 ` [PATCH v10 1/9] nvme-core: Clear any SGL flags in passthru commands Logan Gunthorpe
2019-12-12 23:54 ` [PATCH v10 2/9] nvme: Create helper function to obtain command effects Logan Gunthorpe
2019-12-12 23:54 ` [PATCH v10 3/9] nvme: Move nvme_passthru_[start|end]() calls to common helper Logan Gunthorpe
2019-12-12 23:54 ` [PATCH v10 4/9] nvmet-passthru: Introduce NVMet passthru Kconfig option Logan Gunthorpe
2019-12-12 23:54 ` [PATCH v10 5/9] nvme-core: Introduce nvme_ctrl_get_by_path() Logan Gunthorpe
2019-12-12 23:54 ` [PATCH v10 6/9] nvme: Export existing nvme core functions Logan Gunthorpe
2019-12-12 23:54 ` [PATCH v10 7/9] nvmet-passthru: Add passthru code to process commands Logan Gunthorpe
2019-12-12 23:54 ` [PATCH v10 8/9] nvmet-passthru: Add enable/disable helpers Logan Gunthorpe
2019-12-12 23:54 ` [PATCH v10 9/9] nvmet-configfs: Introduce passthru configfs interface Logan Gunthorpe
2020-01-08 17:40 [PATCH v10 0/9] nvmet: add target passthru commands support Logan Gunthorpe
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).