linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Logan Gunthorpe <logang@deltatee.com>
To: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org
Cc: Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
	Stephen Bates <sbates@raithlin.com>, Jens Axboe <axboe@fb.com>,
	Keith Busch <kbusch@kernel.org>, Max Gurtovoy <maxg@mellanox.com>,
	Logan Gunthorpe <logang@deltatee.com>,
	Christoph Hellwig <hch@lst.de>
Subject: [PATCH v10 1/9] nvme-core: Clear any SGL flags in passthru commands
Date: Thu, 12 Dec 2019 16:54:10 -0700	[thread overview]
Message-ID: <20191212235418.22396-2-logang@deltatee.com> (raw)
In-Reply-To: <20191212235418.22396-1-logang@deltatee.com>

The host driver should decide whether to use SGLs or PRPs and they
currently assume the flags are cleared after the call to
nvme_setup_cmd(). However, passed-through commands may erroneously
set these bits; so clear them for all cases.

Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
---
 drivers/nvme/host/core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index dfe37a525f3a..f71566129d08 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -762,6 +762,8 @@ blk_status_t nvme_setup_cmd(struct nvme_ns *ns, struct request *req,
 	case REQ_OP_DRV_IN:
 	case REQ_OP_DRV_OUT:
 		memcpy(cmd, nvme_req(req)->cmd, sizeof(*cmd));
+		/* passthru commands should let the driver set the SGL flags */
+		cmd->common.flags &= ~NVME_CMD_SGL_ALL;
 		break;
 	case REQ_OP_FLUSH:
 		nvme_setup_flush(ns, cmd);
-- 
2.20.1


_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2019-12-12 23:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-12 23:54 [PATCH v10 0/9] nvmet: add target passthru commands support Logan Gunthorpe
2019-12-12 23:54 ` Logan Gunthorpe [this message]
2019-12-12 23:54 ` [PATCH v10 2/9] nvme: Create helper function to obtain command effects Logan Gunthorpe
2019-12-12 23:54 ` [PATCH v10 3/9] nvme: Move nvme_passthru_[start|end]() calls to common helper Logan Gunthorpe
2019-12-12 23:54 ` [PATCH v10 4/9] nvmet-passthru: Introduce NVMet passthru Kconfig option Logan Gunthorpe
2019-12-12 23:54 ` [PATCH v10 5/9] nvme-core: Introduce nvme_ctrl_get_by_path() Logan Gunthorpe
2019-12-12 23:54 ` [PATCH v10 6/9] nvme: Export existing nvme core functions Logan Gunthorpe
2019-12-12 23:54 ` [PATCH v10 7/9] nvmet-passthru: Add passthru code to process commands Logan Gunthorpe
2019-12-12 23:54 ` [PATCH v10 8/9] nvmet-passthru: Add enable/disable helpers Logan Gunthorpe
2019-12-12 23:54 ` [PATCH v10 9/9] nvmet-configfs: Introduce passthru configfs interface Logan Gunthorpe
2020-01-08 17:40 [PATCH v10 0/9] nvmet: add target passthru commands support Logan Gunthorpe
2020-01-08 17:40 ` [PATCH v10 1/9] nvme-core: Clear any SGL flags in passthru commands Logan Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191212235418.22396-2-logang@deltatee.com \
    --to=logang@deltatee.com \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=maxg@mellanox.com \
    --cc=sagi@grimberg.me \
    --cc=sbates@raithlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).