From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C834C43603 for ; Sun, 15 Dec 2019 12:30:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F029F205C9 for ; Sun, 15 Dec 2019 12:30:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ci1PNvne"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nVrMJK9o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F029F205C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sQ6UZFk2WSPHKAzS61Fs2icfse5+ooVDogD7JJxBdyA=; b=Ci1PNvneZZ+VQe V1uOc4gGoXY9YtkI1v8TUfkqPyGpesz+pbb0UweXo89ckWQnUBN8crQX2nlxe7iTMrz4SwH46XuIr tyQySnQrkMwbjKE7M2WGZQG/MPYW0NTVbVUsuS6rC5+CgXk0HPjKWTqgRLhHZcQDtIpngtNN1rokj fCTUNa9aDWL3rIAFTLb54ZcIg5fGRRI8VIlNbvMaUVQe/RawXvhSlzshVTrKa/lVIIB3XLjxZFo7J lMpzkFEPOsV//k1OcYHmMkgRF/wTBOPxa1Car6f4Mu0oTAaYUpxpwShNsB0I8NRXDcruyEQrzKaV5 +3zkRQJpTE3HBJWXuUOA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1igT26-0003RN-25; Sun, 15 Dec 2019 12:29:58 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1igT22-0003QI-6q for linux-nvme@lists.infradead.org; Sun, 15 Dec 2019 12:29:55 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 91F14205C9; Sun, 15 Dec 2019 12:29:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576412993; bh=2l6Be057Q7FKP+fhTZ0hbvUe6NBP4LC0WK/+kFX+Qzw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nVrMJK9o/bHwLle8h8ijpAz587lP5+UzFmyLzVpLfTk03WtVsGSd0loHEyynmYNq5 ZO+RG0dI/Kx+fn9QH1NyD5MnPsvXc/87YDMePY13Ank41Tf5vh/jWPNIlaByRYCDFY LtYFkKZ5ESKhTJfvAY6m8xnv8KxC7oWcCIvH9fXk= Date: Sun, 15 Dec 2019 12:29:48 +0000 From: Jonathan Cameron To: Akinobu Mita Subject: Re: [PATCH v4 12/12] iio: adc: qcom-vadc-common: use helpers Message-ID: <20191215122948.773bbc42@archlinux> In-Reply-To: <1576386975-7941-13-git-send-email-akinobu.mita@gmail.com> References: <1576386975-7941-1-git-send-email-akinobu.mita@gmail.com> <1576386975-7941-13-git-send-email-akinobu.mita@gmail.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191215_042954_272706_68078886 X-CRM114-Status: GOOD ( 13.79 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hwmon@vger.kernel.org, Lars-Peter Clausen , linux-pm@vger.kernel.org, linux-iio@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Peter Meerwald-Stadler , Hartmut Knaack , akpm@linux-foundation.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Sun, 15 Dec 2019 14:16:15 +0900 Akinobu Mita wrote: > This switches the qcom-vadc-common to use milli_kelvin_to_millicelsius() > in . > > Cc: Jonathan Cameron > Cc: Hartmut Knaack > Cc: Lars-Peter Clausen > Cc: Peter Meerwald-Stadler > Reviewed-by: Andy Shevchenko > Signed-off-by: Akinobu Mita Acked-by: Jonathan Cameron Thanks, > --- > * v4 > - add Reviewed-by tag > > drivers/iio/adc/qcom-vadc-common.c | 6 +++--- > drivers/iio/adc/qcom-vadc-common.h | 1 - > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/adc/qcom-vadc-common.c b/drivers/iio/adc/qcom-vadc-common.c > index dcd7fb5..2bb78d1 100644 > --- a/drivers/iio/adc/qcom-vadc-common.c > +++ b/drivers/iio/adc/qcom-vadc-common.c > @@ -6,6 +6,7 @@ > #include > #include > #include > +#include > > #include "qcom-vadc-common.h" > > @@ -236,8 +237,7 @@ static int qcom_vadc_scale_die_temp(const struct vadc_linear_graph *calib_graph, > voltage = 0; > } > > - voltage -= KELVINMIL_CELSIUSMIL; > - *result_mdec = voltage; > + *result_mdec = milli_kelvin_to_millicelsius(voltage); > > return 0; > } > @@ -325,7 +325,7 @@ static int qcom_vadc_scale_hw_calib_die_temp( > { > *result_mdec = qcom_vadc_scale_code_voltage_factor(adc_code, > prescale, data, 2); > - *result_mdec -= KELVINMIL_CELSIUSMIL; > + *result_mdec = milli_kelvin_to_millicelsius(*result_mdec); > > return 0; > } > diff --git a/drivers/iio/adc/qcom-vadc-common.h b/drivers/iio/adc/qcom-vadc-common.h > index bbb1fa0..e074902a 100644 > --- a/drivers/iio/adc/qcom-vadc-common.h > +++ b/drivers/iio/adc/qcom-vadc-common.h > @@ -38,7 +38,6 @@ > #define VADC_AVG_SAMPLES_MAX 512 > #define ADC5_AVG_SAMPLES_MAX 16 > > -#define KELVINMIL_CELSIUSMIL 273150 > #define PMIC5_CHG_TEMP_SCALE_FACTOR 377500 > #define PMIC5_SMB_TEMP_CONSTANT 419400 > #define PMIC5_SMB_TEMP_SCALE_FACTOR 356 _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme