[PATCH] nvme-cli: Fix systemd service script use of CONNECT_ARGS env var

[PATCH] nvme-cli: Fix systemd service script use of CONNECT_ARGS env var

[James Smart]

In testing, some environments are not properly expanding CONNECT_ARGS.

Change systemd service file use of CONNECT_ARGS to be encapsulated by
apostrophes and parens.

Signed-off-by: James Smart <jsmart2021@gmail.com>
---
 nvmf-autoconnect/systemd/nvmf-connect@.service | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nvmf-autoconnect/systemd/nvmf-connect@.service b/nvmf-autoconnect/systemd/nvmf-connect@.service
index 10fb3aa..c60f146 100644
--- a/nvmf-autoconnect/systemd/nvmf-connect@.service
+++ b/nvmf-autoconnect/systemd/nvmf-connect@.service
@@ -11,4 +11,4 @@ Requires=nvmf-connect.target
 [Service]
 Type=simple
 Environment="CONNECT_ARGS=%i"
-ExecStart=/bin/sh -c "nvme connect-all --quiet `/bin/echo -e $CONNECT_ARGS`"
+ExecStart=/bin/sh -c "nvme connect-all --quiet `/bin/echo -e '${CONNECT_ARGS}'`"
-- 
2.13.7


_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

Re: [PATCH] nvme-cli: Fix systemd service script use of CONNECT_ARGS env var

[James Smart]

ping...

On 12/19/2019 11:05 AM, James Smart wrote:
> In testing, some environments are not properly expanding CONNECT_ARGS.
>
> Change systemd service file use of CONNECT_ARGS to be encapsulated by
> apostrophes and parens.
>
> Signed-off-by: James Smart <jsmart2021@gmail.com>
> ---
>   nvmf-autoconnect/systemd/nvmf-connect@.service | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/nvmf-autoconnect/systemd/nvmf-connect@.service b/nvmf-autoconnect/systemd/nvmf-connect@.service
> index 10fb3aa..c60f146 100644
> --- a/nvmf-autoconnect/systemd/nvmf-connect@.service
> +++ b/nvmf-autoconnect/systemd/nvmf-connect@.service
> @@ -11,4 +11,4 @@ Requires=nvmf-connect.target
>   [Service]
>   Type=simple
>   Environment="CONNECT_ARGS=%i"
> -ExecStart=/bin/sh -c "nvme connect-all --quiet `/bin/echo -e $CONNECT_ARGS`"
> +ExecStart=/bin/sh -c "nvme connect-all --quiet `/bin/echo -e '${CONNECT_ARGS}'`"


_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

Re: [PATCH] nvme-cli: Fix systemd service script use of CONNECT_ARGS env var

[Keith Busch]

On Thu, Dec 19, 2019 at 11:05:34AM -0800, James Smart wrote:
> In testing, some environments are not properly expanding CONNECT_ARGS.
> 
> Change systemd service file use of CONNECT_ARGS to be encapsulated by
> apostrophes and parens.
> 
> Signed-off-by: James Smart <jsmart2021@gmail.com>

Patch applied, sorry for the delay.

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme